fix(frontend): fix new notebook URL using wrong file query param#9603
Open
loliuy wants to merge 1 commit into
Open
fix(frontend): fix new notebook URL using wrong file query param#9603loliuy wants to merge 1 commit into
loliuy wants to merge 1 commit into
Conversation
newNotebookURL() was building ?file=__new__<sessionId>, but the backend's parse_file_key only recognises the exact sentinel __new__. The suffixed value was treated as a file path, causing a 404 on every new notebook open. Fix by separating the two concerns: pass file=__new__ as the notebook key and session_id=<id> as the session identifier, consistent with how existing (unsaved) notebooks are linked from the home page. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newNotebookURL() was building ?file=new, but the backend's parse_file_key only recognises the exact sentinel new. The suffixed value was treated as a file path, causing a 404 on every new notebook open.
Fix by separating the two concerns: pass file=new as the notebook key and session_id= as the session identifier, consistent with how existing (unsaved) notebooks are linked from the home page.
📝 Summary
Closes #
📋 Pre-Review Checklist
✅ Merge Checklist
I have read the CLA Document and I hereby sign the CLA