Update children view._index when reordering#2579
Closed
bogdanb wants to merge 1 commit intomarionettejs:masterfrom
Closed
Update children view._index when reordering#2579bogdanb wants to merge 1 commit intomarionettejs:masterfrom
bogdanb wants to merge 1 commit intomarionettejs:masterfrom
Conversation
Without this change, the CollectionView will not react upon moving a child view back immediately after a change. Example: when creating a view for collection [a, b], the views will have indexes [va.0, vb.1]. If we switch the order to [b, a], the views will retain their indexes while changing their position, i.e. [vb.1, va.0]. (The view is correctly reordered.) If we then switch the order again to [a, b], the test in _sortViews() will think that the order has not changed, and the views will remain in positions [vb, va]. (Depending on the situation, a call to _updateIndices() might fix this.)
Member
|
thanks for the PR @bogdanb this has already been fixed here: ahumphreys87@e787839 It is pending release of 2.4.2 which is very close. You can track its progress here: #2532 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, the CollectionView will not react upon moving a child view back immediately after it was reordered.
Example: when creating a view for collection [a, b], the views will have indexes [va.0, vb.1]. If we switch the order to [b, a], the views will retain their indexes while changing their position, i.e. [vb.1, va.0]. (The view is correctly reordered.) If we then switch the order again to [a, b], the test in _sortViews() will think that the order has not changed, and the views will remain in positions [vb, va].
(Depending on the situation, a call to _updateIndices() might fix this.)