fix: fall back to userPrincipalName when mail is empty in AzureADv2#638
Open
Yanhu007 wants to merge 1 commit intomarkbates:masterfrom
Open
fix: fall back to userPrincipalName when mail is empty in AzureADv2#638Yanhu007 wants to merge 1 commit intomarkbates:masterfrom
Yanhu007 wants to merge 1 commit intomarkbates:masterfrom
Conversation
Many Azure AD users have a null/empty "mail" field while their "userPrincipalName" contains a valid email address. Fall back to userPrincipalName when mail is empty so the Email field is populated. Fixes markbates#289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289
Problem
The AzureADv2 provider maps
user.Emailfrom the Microsoft Graph APImailfield. However, many Azure AD accounts (especially personal Microsoft accounts and some organizational accounts) havemailas null/empty whileuserPrincipalNamecontains their email address.This results in an empty
Emailfield on the returned user.Fix
Fall back to
userPrincipalNamewhenmailis empty:This matches the approach used by other OAuth providers (e.g., Google) that check multiple fields for email.