This repository was archived by the owner on Nov 9, 2022. It is now read-only.
Clear search from details page with trash icon #268 - #280
Open
kghmanuel wants to merge 1 commit into
Open
Conversation
… button. 2. clear results without affecting the cache mechanism inplace.
Contributor
|
Thanks for this, looks very promising. I'd like to run a local test before merging, just to make sure it behaves well in all circumstances. Unfortunately, I'll have to postpone that for now.. |
Contributor
|
PS: did you check how well this works together with the latest ml-search-ng that you added in one of your other PRs? |
Author
|
Still works as expected. However, ... The negative facets being tracked by the other pull request does not get affected by clear. i would have to rethink the other pull request regarding this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #268