Skip to content

Solution#3612

Open
Hawkbaster wants to merge 3 commits into
mate-academy:masterfrom
Hawkbaster:develop
Open

Solution#3612
Hawkbaster wants to merge 3 commits into
mate-academy:masterfrom
Hawkbaster:develop

Conversation

@Hawkbaster

Copy link
Copy Markdown

Solution for the exersice

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there is still a critical mismatch with the task’s mutability classification, which is part of the core requirements. In app/main.py, your sorted_variables dictionary currently places collection_of_coins (a set) inside the "mutable" list, but the task’s teaching goal is to treat only list and dict as mutable here, with int, float, bool, str, tuple, and set grouped as immutable. This means that sorted_variables["mutable"] should contain only my_favourite_films and marks, while collection_of_coins must be moved into sorted_variables["immutable"] alongside the other non-list/non-dict types [CHECKLIST ITEM #2, #3, #6]. To fix this, update the sorted_variables dictionary so that collection_of_coins is removed from the "mutable" list and added to the "immutable" list, making sure all eight variables are still present across the two lists. Once you correct that grouping, your solution will fully meet the task requirements and the classification logic will align with the mutability concept the exercise is testing. Keep the rest of your structure as-is, because your variable definitions and overall dictionary shape are otherwise correct and well done.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py Outdated

# write your code here
sorted_variables = {
"mutable": [my_favourite_films, marks, collection_of_coins],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collection_of_coins is currently grouped under "mutable", but according to the task you should only store truly mutable structures (like lists and dicts) there; move collection_of_coins into the "immutable" list so that "mutable" contains only my_favourite_films and marks, and "immutable" contains the remaining variables.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because one core requirement about mutability classification is still not met, which is considered a blocking issue for this task. In app/main.py, your sorted_variables["mutable"] list currently includes collection_of_coins, but according to the exercise’s rules it must contain only my_favourite_films (list) and marks (dict) [CHECKLIST ITEM #2, #3]. Likewise, collection_of_coins (the set) is missing from sorted_variables["immutable"], even though the task explicitly requires that, for this exercise, it be grouped with the immutable types [CHECKLIST ITEM #6].

To fix this, update the sorted_variables dictionary so that:

  • sorted_variables["mutable"] contains exactly my_favourite_films and marks, in a list.
  • sorted_variables["immutable"] contains the other six variables, including collection_of_coins, with no omissions or duplicates.
    You’ve otherwise set up the variables and dictionary structure correctly, so once you adjust this classification, your solution should fully satisfy the task requirements. Keep going—you’re very close to a perfect submission.

✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py Outdated

# write your code here
sorted_variables = {
"mutable": [my_favourite_films, marks, collection_of_coins],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted_variables["mutable"] should contain only my_favourite_films and marks per the task’s mutability classification; collection_of_coins must be moved to the "immutable" list, and all eight variables must appear across the two lists without omission or duplication (checklist items #2, #3, #6).

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it fully meets the exercise requirements: you defined eight variables of different data types and correctly organized them into the sorted_variables dictionary with exactly the two keys "mutable" and "immutable". The "mutable" list correctly includes only the list my_favourite_films and the dictionary marks, while the "immutable" list contains the remaining six variables, including collection_of_coins, with no duplicates or omissions. This shows a solid understanding of how Python distinguishes between mutable and immutable data types and how to structure data in dictionaries and lists.

There are no critical or minor issues to fix for this task; your implementation is clean, correct, and aligned with the instructions. Keep paying attention to clear naming and consistent structure like this, as it will help you a lot in more complex exercises. Nicely done—this is a strong, requirement-compliant solution.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants