Skip to content

feat: add cpp folder icons #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorduino wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add cpp folder icons #3306

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
205fba9
feat: add C and C++ folder icons
jorduino Dec 29, 2025
5ff5b8d
feat: add c# folder icons
jorduino Dec 30, 2025
d0ad2fd
Merge branch 'main' into cpp-folder-icon
jorduino Jan 5, 2026
c85ad8e
Merge branch 'material-extensions:main' into cpp-folder-icon
jorduino Jan 8, 2026
77e7495
new c++ folder design
jorduino Jan 9, 2026
0ee87f9
feat: new c and csharp folder icon
jorduino Jan 9, 2026
a34ac28
Merge branch 'main' into cpp-folder-icon
jorduino Jan 14, 2026
e91c1e7
Merge branch 'material-extensions:main' into cpp-folder-icon
jorduino Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions icons/folder-c-open.svg
View file
Open in desktop
Copy link
Copy Markdown
Member

@PKief PKief Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I've reviewed the icons, and I've the feeling that the motifs are still a little bit small compared to our other folder icons. So maybe we can adjust the design here a little bit so that it fits better.

Additionally, the c++ icon looks different on the file and for the folders:

Image

Usually, we try to have some consistent styling here.

Copy link
Copy Markdown
Author

@jorduino jorduino Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree with what you're saying about the C++ folder, and personally I think the C# folder is worse at adhering to the file icon design.

The problem I was running into is trying to align the ++ to the middle of the C while keeping it aligned to the grid, but I found a compromise. I aligned the ++ to the grid and to the middle of the C, but increased the C by 1 pixel (now exactly half of the scale of the file icon).

This puts the C slightly off of the grid, but to my eye it doesn't add any blur at 16x16. Please let me know what you think and I will update the C and C# folders to align with this design as well if it works

Copy link
Copy Markdown
Author

@jorduino jorduino Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the C and C# folder icons and I think they look better now.

The C glyph looks ever so slightly blurrier, but I don't think it's too bad at this scale:
new-c-and-friends

The folder icons still don't look exactly the same as the file icons, but I couldn't find anything that looked better at that scale.

This is using the same icon for the file just scaled down by 0.5x:
bad-cpp-folder-1

And here at full scale, obviously way too big:
crazy-cpp-folder-1

The problem is the ++ in the file icon is 1px wide and can't be scaled down any without losing clarity. Hopefully these icons work, let me know what you think.

Copy link
Copy Markdown
Member

@PKief PKief Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, I'm little bit busy at the moment. I need to spend some time to play around with your suggestions, I'm not sure if we can merge it like that. But it's on my list and I'll come back to it when there's little more time. Keep your PR open for now, it has potential.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/folder-c.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/folder-cpp-open.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/folder-cpp.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/folder-csharp-open.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/folder-csharp.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions src/core/icons/folderIcons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@ export const folderIcons: FolderTheme[] = [
name: 'folder-css',
folderNames: ['css', 'stylesheet', 'stylesheets', 'style', 'styles'],
},
{
name: 'folder-cpp',
folderNames: ['cpp', 'cplusplus', 'c++'],
},
{
name: 'folder-csharp',
folderNames: ['csharp', 'c#', 'cs'],
},
{
name: 'folder-c',
folderNames: ['c'],
},
{ name: 'folder-sass', folderNames: ['sass', 'scss'] },
{ name: 'folder-television', folderNames: ['tv', 'television'] },
{ name: 'folder-desktop', folderNames: ['desktop', 'display'] },
Expand Down