feat: add Kubernetes icon for files#3373
feat: add Kubernetes icon for files#3373Sagbyy wants to merge 2 commits intomaterial-extensions:mainfrom
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
|
Following file and folder icons already exists.
|
| }, | ||
| { | ||
| name: 'kubernetes-manifest', | ||
| fileNames: [ |
There was a problem hiding this comment.
This list is comprehensive, however for some fileNames we cannot allow them to have the kubernetes icon. Lets say someone is using "job.yml" because he created a job portal to allow people to search for jobs and he's saving some config there - or whatever data which is not related to kubernetes, the icon doesn't make sense anymore. Same for secret.yml, why should we always show the kubernetes manifest icon for this file name even if it's not used with kubernetes at all? This will be confusing for everyone. That's why I think it will be difficult to get this PR merged with of all these changes.
There was a problem hiding this comment.
Agree, a lot of those fileNames suits a user custom config in vscode more than a general config for all users. svc.yml, namespace.yml, quota.yml, role.yml, secret.yml, cronjob.yml, etc. are too generic. I'm sure I've used some of these names for non-k8s stuff.
There was a problem hiding this comment.
Hi @PKief, thanks for your comment! Is it possible to display an icon using another method, such as displaying it based on YAML content specific to Kubernetes?
There was a problem hiding this comment.
@Sagbyy kind of. VS Code has these language IDs. That means VS Code scans every file you open and finds a language ID for that file (https://code.visualstudio.com/docs/languages/identifiers). And we (as extension maintainers) can assign icons for language IDs. This means that we wouldn't assign all the filenames or file extensions to an icon, but just the language ID. You can find the name is the name of the icon and the ids the list of language ids to which we assign an icon: https://github.com/material-extensions/vscode-material-icon-theme/blob/main/src/core/icons/languageIcons.ts
4 participants
Description
Add the Kubernetes icon to the resources file.
I have applied the suggestions that were previously requested on this PR #2077
Contribution Guidelines