Skip to content

Update meta.yml and require Rocq 9.0#124

Merged
pi8027 merged 1 commit intomasterfrom
meta_yml
Mar 25, 2026
Merged

Update meta.yml and require Rocq 9.0#124
pi8027 merged 1 commit intomasterfrom
meta_yml

Conversation

@pi8027
Copy link
Copy Markdown
Member

@pi8027 pi8027 commented Mar 24, 2026

#123 (comment)

Also, I think it's the right time to start requiring Rocq 9.0. It allows us to refactor the proof scripts, but I will do it later.

@pi8027 pi8027 requested a review from proux01 March 24, 2026 13:50
| "rocq-core" {>= "9.0"})
"coq-mathcomp-ssreflect" {>= "2.4"}
"coq-mathcomp-algebra"
"rocq-core" {>= "9.0"}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, the Rocq-community templates don't let us replace coq with rocq-core here yet.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 25 to 26
"coq-mathcomp-bigenough"
"coq-mathcomp-finmap"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be

Suggested change
"coq-mathcomp-bigenough"
"coq-mathcomp-finmap"
"rocq-mathcomp-bigenough"
"rocq-mathcomp-finmap"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I performed this change, and it breaks finmap in CI.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I guess the thing is that only coq-mathcomp-finmap has the dev version. This should be fixed in the opam repo.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And bigenough has the same issue.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm preparing a patch.)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the change.

@pi8027
Copy link
Copy Markdown
Member Author

pi8027 commented Mar 24, 2026

@proux01 To answer your comment (#123 (comment)), we need to patch two lines in the new opam file (rocq-core and conflicts) manually. But, using the templates is still beneficial; for example, it automatically updates the installation instructions in README.

@pi8027 pi8027 merged commit 7d6def0 into master Mar 25, 2026
7 checks passed
@pi8027 pi8027 deleted the meta_yml branch March 25, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants