feature: add floatingTabBehavior option for browser-style floating tab management (#1161)#1166
Open
shay-dr wants to merge 1 commit intomathuo:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5eae784:
|
b564539 to
6f66bdb
Compare
Author
|
I forgot to sign, hence my force push. |
Owner
|
Could you remove the |
a1f7faf to
5eae784
Compare
…b management (mathuo#1161) Add a `floatingTabBehavior` configuration option to DockviewOptions. When set to `"browser"`, dragging a tab onto a different floating group merges it into the target group, and tearing a tab out of a multi-tab floating group creates a new floating group at the drop position instead of docking to the grid. Default behavior is unchanged.
Author
|
@mathuo done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1161
Adds a
floatingTabBehavioroption toDockviewOptionswith two modes:"default"(or omitted): No behavior change — full backward compatibility"browser": Enables two features:How it works
canDisplayOverlay, when the mouse is over a non-source floating group, the root drop target suppresses its overlay so the floating group's own Droptarget can handle the eventonDrop, when a tab is torn from a multi-tab floating group,addFloatingGroupis called instead oforthogonalizefloatingTabBehavior === 'browser'— zero impact on default behaviorChanges
options.ts: AddfloatingTabBehaviortoDockviewOptionsandPROPERTY_KEYS_DOCKVIEWdockviewComponent.ts: Root overlay suppression + tear-off-to-float logic +_isMouseOverNonSourceFloatingGrouphelperTest details
floatingTabBehavior="browser"