feat: add tabGroupIndicator theme property and extract wrap underline…#1172
Merged
feat: add tabGroupIndicator theme property and extract wrap underline…#1172
Conversation
… logic Add a `tabGroupIndicator` property to `DockviewTheme` that controls how tab groups are visually indicated: 'wrap' (default SVG wrap-around) or 'none' (pure CSS via tab classes and --dv-tab-group-color custom property). Extract the ~480-line SVG wrap underline logic from TabGroupManager into a self-contained WrapTabGroupIndicator class behind an ITabGroupIndicator interface, reducing TabGroupManager from 892 to 541 lines. Set the abyss theme to use 'none' mode with a pure CSS box-shadow indicator as a demonstration of CSS-only tab group styling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 146851a:
|
…cator generic Move the pure-CSS tab group indicator styles out of the abyss theme mixin into a generic .dv-tab-group-indicator-none rule so any theme can opt in via the tabGroupIndicator property. Toggle the class on the dockview root element when the mode changes so switching back to 'wrap' properly clears the CSS-only styles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reduces code duplication in WrapTabGroupIndicator flagged by SonarCloud. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…/theme-tab-group-indicator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… logic
Add a
tabGroupIndicatorproperty toDockviewThemethat controls how tab groups are visually indicated: 'wrap' (default SVG wrap-around) or 'none' (pure CSS via tab classes and --dv-tab-group-color custom property).Extract the ~480-line SVG wrap underline logic from TabGroupManager into a self-contained WrapTabGroupIndicator class behind an ITabGroupIndicator interface, reducing TabGroupManager from 892 to 541 lines.
Set the abyss theme to use 'none' mode with a pure CSS box-shadow indicator as a demonstration of CSS-only tab group styling.