Open
Conversation
Introduce DockviewModule interface, ModuleRegistry, and ServiceCollection as the foundation for decomposing dockview-core into independent feature modules. This enables future tree-shaking and community/enterprise split. - New modules.ts with DockviewModule type, ModuleRegistry class - modules option added to DockviewOptions and PROPERTY_KEYS_DOCKVIEW - DockviewComponent creates and exposes ModuleRegistry - Framework wrappers (React, Vue, Angular) forward modules option - No features moved, all 998 tests pass Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move floating group management into a dedicated FloatingGroupService behind the module system. This validates the module extraction pattern that will be used for all 16 planned modules. - New IFloatingGroupService interface and FloatingGroupService class managing the floating groups array, lifecycle, bounds, serialization - New FloatingGroupModule that registers the service via factory - ModuleRegistry gains initialize(host) for service instantiation - DockviewComponent delegates all 15 floating group touchpoints to the service via optional chaining - Auto-registers FloatingGroupModule when no explicit modules option is provided, preserving full backward compatibility - All 998 tests pass unchanged across all packages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 732117e:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses