feat: move tabAnimation to theme object and combine sidebar#1181
Open
feat: move tabAnimation to theme object and combine sidebar#1181
Conversation
Move tabAnimation from DockviewOptions to DockviewTheme so it sits alongside other visual/behavioral theme properties like dndTabIndicator and tabGroupIndicator. Merge the settings modal and theme builder into a single collapsible sidebar with a Theme/Controls tab toggle, and restyle the controls components to match the sidebar aesthetic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64bd0e1:
|
…theme-sidebar # Conflicts: # packages/docs/sandboxes/react/dockview/demo-dockview/src/themeBuilderModal.tsx # packages/docs/sandboxes/react/dockview/tabview/src/app.tsx # packages/docs/templates/dockview/tab-groups/react/src/app.tsx # packages/docs/templates/dockview/tabview/react/src/app.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tabAnimation from DockviewOptions to DockviewTheme so it sits alongside other visual/behavioral theme properties like dndTabIndicator and tabGroupIndicator. Merge the settings modal and theme builder into a single collapsible sidebar with a Theme/Controls tab toggle, and restyle the controls components to match the sidebar aesthetic.
Description
Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
Checklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses