Simplified MatrixBus API - #22
Open
jeikabu wants to merge 1 commit into
Open
Conversation
jeikabu
commented
May 9, 2020
jeikabu
commented
Contributor
- Move address parameter to MatrixBus trait, impls are now responsible for packing/formatting as required by the platform
- esp32_everloop example uses ESP-IDF v3.3 and must use older esp_idf_build
- Tested on Voice using kernel module and ESP32
- Move address parameter to MatrixBus trait, impls are now responsible for packing/formatting as required by the platform - esp32_everloop example uses ESP-IDF v3.3 and must use older esp_idf_build - Tested on Voice using kernel module and ESP32
jeikabu
commented
May 9, 2020
jeikabu
left a comment
jeikabu
left a comment
Contributor
Author
There was a problem hiding this comment.
Main omissions:
- Testing Creator's additional sensors (I lack the hardware)
- Doc/comment updates; would prefer to wait until the API looks more "final"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.