Various improvements to speed and a11y - #143
Open
Lunarequest wants to merge 9 commits into
Open
Conversation
preload fonts patch font awesome to use font-display:swap
fix fonts upgrade fontawesome 6.3.0
add support for aria-label for social link
use fontawesome's kits. they are just smaller and better use fontawesome's kits. they are just smaller and better use fontawesome's kits. they are just smaller and better use fontawesome's kits. they are just smaller and better
Contributor
Author
|
note with the addition of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a while optimizing harbor. I've made some major changes like using fontawesome 6's JS kit as it is significantly faster over using the webfonts with fontawesome 5.
I switch to fontawesome 6 for the mastodon icon amongst many others. The biggest single improvement has been using derfer for font awesome and placing it at the end caused the performance metric in https://pagespeed.web.dev to jump from 85 -> 95!
Overall I believe this should bring a ton of benefits to the users as I've also added a handful of aria-labels to improve a11y. I'll be moving away from hugo soon so I figured i should upstream the changes I've made so that it can benefit others.