fix(node): restore group endpoint mappings at startup - #4055
Merged
Conversation
GroupKeyManagement restored group key sets and the group key map from persisted state at startup, but not the runtime endpoint map derived from the group table. Group commands to persisted groups were silently not dispatched after a restart (and binding group-member lookups came up empty) until an AddGroup command repopulated the map. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Restores runtime group→endpoint mappings (fabric.groups.endpoints) from persisted groupTable during GroupKeyManagementServer#online(), so group command dispatch and group-member lookups continue to work after a node restart.
Changes:
- Rebuild
fabric.groups.endpointsat startup by iterating the persistedgroupTable. - Ensure restored mappings are populated per-fabric only when that fabric exists.
Apollon77
added
the
automerge
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GroupKeyManagementServer#online()restores the group key sets and the group key map from persisted state, but not the runtime endpoint map derived from the persistedgroupTable— that only happens in the fabric-replace handler. After a node restart:session.subject.endpoints→fabric.groups.endpoints, which is empty — commands to previously configured groups are silently not dispatched,BindingManagergroup-member lookups come up empty as well,until a fresh
AddGrouprepopulates the map. CI never restarts a configured node mid-test, so this went unnoticed.Fix
Rebuild
fabric.groups.endpointsfrom the persistedgroupTablefor every loaded fabric at startup, mirroring the existing key-map restore.Found during the Groupcast branch (#3298) final review; this part is legacy-relevant independent of Groupcast and applies to the Matter 1.6.0 line.
🤖 Generated with Claude Code