-
Notifications
You must be signed in to change notification settings - Fork 117
feat: ClientNode controller API additions + deprecate legacy controller API #4091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Apollon77
wants to merge
72
commits into
main
Choose a base branch
from
feat/clientnode-controller-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 67 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
814a572
feat(node): add Behaviors.forCluster and cluster name/id resolver
Apollon77 d5fe0d3
feat(node): add Peers.commissioned view
Apollon77 187bd20
feat(node): add NodeLifecycle.isSeeded/seeded
Apollon77 181b4f4
feat(node): add commissioning-window helpers on CommissioningClient/C…
Apollon77 218f6a4
feat(protocol): emit establishment-unresponsive signal after MRP budg…
Apollon77 de8771b
feat(node): connection-state engine on NetworkClient exposed via Node…
Apollon77 3a45073
fix(node): redefine connection-state Disconnected as stopped/not-started
Apollon77 3b9fad2
fix(node): dispose seeded listener after latch; document startup-time…
Apollon77 5f9e8b1
refactor(types): relocate cluster name/id resolver to ClusterHelper w…
Apollon77 e8a0504
chore(matter.js): deprecate legacy controller/device API for 0.19 rem…
Apollon77 df9bfec
docs: add controller migration guide (MIGRATION_CONTROLLER_018, WIP)
Apollon77 b1ea69c
fix(node): register peer BasicInformation handlers once to prevent du…
Apollon77 fd2faeb
fix(node): register bridged ConfigurationVersion handler once
Apollon77 8c4d016
docs: fill migration guide subscription/event-bus/FAQ sections with c…
Apollon77 24e07fc
Potential fix for pull request finding
Apollon77 b68c500
docs: map legacy autoConnect/autoSubscribe to NetworkClient state in …
Apollon77 e4a4504
docs: document node enable/disable and automatic bulk connect in migr…
Apollon77 89adb50
docs: lead event-bus migration with ChangeNotificationService aggrega…
Apollon77 4a1ee17
refactor(node): split client-only lifecycle surface into ClientNodeLi…
Apollon77 2fa68ae
refactor(types): group cluster name/id resolvers under ClusterLookup …
Apollon77 590234d
chore: stop tracking local plan doc, gitignore docs/superpowers
Apollon77 41e9e47
feat(shell): add ServerNode/peers-backed ClientNode methods to Matter…
Apollon77 2b62169
fix(shell): tear down subscription via disable() for autoConnect:fals…
Apollon77 819712b
refactor(shell): migrate cmd_nodes to ClientNode/peers
Apollon77 e7a5f6b
fix(shell): migrate cmd_nodes fabric lookup + OTA off legacy Commissi…
Apollon77 b7fc1a9
refactor(shell): migrate cmd_commission to ClientNode API
Apollon77 303bdc3
refactor(shell): migrate cluster attribute/command/event commands to …
Apollon77 db06cad
refactor(shell): migrate cmd_subscribe to auto-subscribe + ChangeNoti…
Apollon77 e873862
refactor(shell): migrate cmd_icd to ClientNode lifecycle/IcdClient
Apollon77 9bf817e
refactor(shell): migrate cmd_identify/session/discover to ClientNode/…
Apollon77 d24f902
refactor(shell): remove CommissioningController backing, finalize Cli…
Apollon77 a992c0d
fix(shell): tidy cmd_icd watch teardown and restore cmd_discover dedupe
Apollon77 a726192
fix(shell): defer controller node creation/start to first use (restor…
Apollon77 6cb04a6
feat(node): add NetworkServer.autoStartCommissionedPeers opt-out for …
Apollon77 6dbed91
fix(shell): opt out of peer auto-connect, connect/subscribe on demand
Apollon77 a7c6ef4
docs: document NetworkServer.autoStartCommissionedPeers in controller…
Apollon77 5264c27
fix(shell): normalize autoSubscribe once at startup so connect no lon…
Apollon77 57271a3
fix(shell): enable disabled peers on connect
Apollon77 46bbe96
docs: clarify autoStartCommissionedPeers=false requires explicit enab…
Apollon77 90ed9ad
fix(shell): controller uses ephemeral operational port, not standard …
Apollon77 e5b05e7
feat(node): default controller operational port to ephemeral when unset
Apollon77 b2d7be0
fix(shell): drop port:0 workaround now handled by the library
Apollon77 b26b1ed
fix(shell): restore OTA field guards, promise-cache node lifecycle, r…
Apollon77 51151a3
docs: complete controller migration guide from the shell blueprint (d…
Apollon77 9b023d7
Merge remote-tracking branch 'origin/main' into worktree-feat+clientn…
Apollon77 eff26ae
feat(shell): close phase-2 ClientNode migration gaps
Apollon77 76677ff
refactor(shell): format seeded-wait timeout with Duration.format
Apollon77 d9fba6c
Merge branch 'main' into feat/clientnode-controller-api
Apollon77 ae6f2ad
docs: clarify autoStartCommissionedPeers vs per-node disable use cases
Apollon77 64844c8
fix: address #4091 review comments (passcode logging, establishment o…
Apollon77 273be0e
docs(migration): fabric-label propagation recipe, negotiated interval…
Apollon77 362e79d
feat(node): add Peers.completeCommissioning for split commissioning
Apollon77 dbae66e
fix(node): seed discoveryData on live peer + clean up on completeComm…
Apollon77 fe5c3d4
test(node): cover completeCommissioning non-Ok CommissioningComplete …
Apollon77 8d5fce8
docs: document finalizeCommissioning PASE-only + split-commissioning …
Apollon77 8638943
fix(node): guard completeCommissioning against deleting an already-co…
Apollon77 850d730
test(node): deterministically await re-announcement in failsafe commi…
Apollon77 277449f
feat(node): send CommissioningComplete with extended failsafe respons…
Apollon77 6c46f76
fix(node): persist fabric before the node in completeCommissioning (b…
Apollon77 cca8dfd
fix(node): require an existing shared fabric in completeCommissioning
Apollon77 28b2531
test(node): cover completeCommissioning rejecting when the shared fab…
Apollon77 a4b80b2
test(node): comment audit — drop WHAT-restating comments, fix stale i…
Apollon77 6ff62ca
docs(node): finalizeCommissioning is awaited — document return/throw …
Apollon77 19e9038
Merge branch 'main' into feat/clientnode-controller-api
Apollon77 5c6d828
fix(node): address final review — completeCommissioning seeding + polish
Apollon77 80d7979
fix: address #4091 PR review comments
Apollon77 a5c301a
Merge branch 'main' into feat/clientnode-controller-api
Apollon77 547483c
fix(shell): reject partial ip/port in commission command
Apollon77 6c6b4f6
Merge branch 'main' into feat/clientnode-controller-api
Apollon77 062facd
Merge branch 'main' into feat/clientnode-controller-api
Apollon77 b762c2b
Merge remote-tracking branch 'origin/main' into feat/clientnode-contr…
Apollon77 533ef8a
docs(changelog): move unreleased controller-API entries to WORK IN PR…
Apollon77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,6 @@ isolated-*.log | |
| /.caude/ | ||
| .claude/ | ||
| docs/plans/ | ||
|
|
||
| # Local planning/SDD scratch (never committed) | ||
| docs/superpowers/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.