-
Notifications
You must be signed in to change notification settings - Fork 46
Add --hci-id argument to python_ble_proxy #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2myaus
wants to merge
8
commits into
matter-js:main
Choose a base branch
from
2myaus:python_ble_proxy_hci_id_arg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−7
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
acf2fc0
add --hci-id argument to matter_ble_proxy
2myaus 793dbc3
replace removed docstring/comment
2myaus 00537d9
Resolve type issues
2myaus a4eac26
Merge branch 'matter-js:main' into python_ble_proxy_hci_id_arg
2myaus b5dea1f
improve clarity of OS limitations for --hci-device in python BLE proxy
2myaus 2265b45
Merge branch 'main' into python_ble_proxy_hci_id_arg
Apollon77 156838f
Add version check for BLE adapter argument in bleak
2myaus 9221cba
Merge branch 'main' into python_ble_proxy_hci_id_arg
Apollon77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the flag is
--hci-idand the argparse dest ishci_id, but this parameter ishci_device. Renaming it tohci_idwould keep one name end-to-end (BleakScanSource(hci_id=args.hci_id)).