[MM-67519] Remove clean path name - #3699
Conversation
|
@Rajat-Dabade this has the sample build for testing the Boards history module We should not merge this until we've decided when we should introduce a breaking change for previous Boards versions. |
|
❌ E2E Test Setup Failed Failed to create E2E test instances: failed to create installation: failed with status code 409 |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
/update-branch |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough
ChangesBrowser-history path forwarding
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
/update-branch |
Summary
In cases where a team name is the same as the subpath name in a URL (eg.
https://foo.bar/foo/foo/test, wherefoois the team name andtestis the channel name), the Desktop App browser history logic gets confused and will treatfooas the channel name and remove the secondfoo, resulting in a Team not found error.We added this because Boards uses a different browser history module, and it does not account for the basename when setting up the navigation. However, we will be changing that over, so this PR will remove that extra path cleaning logic altogether.
Ticket Link
https://mattermost.atlassian.net/browse/MM-67519
Change Impact: 🟡 Medium
Regression Risk: The change affects browser-history behavior in the Desktop App. The removed automated test reduces coverage for subpath server navigation.
QA Recommendation: Perform manual testing with subpath servers and team names that match server subpaths. Test Boards navigation and previous Boards versions.
Generated by CodeRabbitAI