Closed
Conversation
Format each argument as a json string and join on newline
I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.
Author
|
A coincident merge makes this PR conflict with src/string_utils.hh. In addition, json.hh now includes string_utils.hh, complicating my changes. I think the way to fix is to break out a quoting.hh from string_utils.hh, but I'd appreciate guidance from someone more familiar with the code. |
Owner
|
I am not sure how much value json quoting has in the first place as we still only emit a list of strings. I would like to see a use case where using the existing mechanisms is much more cumbersome before adding this. You can, for example, trivially get the list of strings in "$@" with |
Author
|
I just opened an updated PR (#5217) that is compatible with current master. I'll respond over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add -quoting json option to echo. This converts each argument to a json string and joins on newline. It supports this, for example:
A script can obtain potentially large sets of strings, like selections, as input rather than environment.