Open
Conversation
mawww
reviewed
Aug 11, 2025
| == Comments parsing | ||
|
|
||
| Commands are commented out after `#` until end of line (not `;`). | ||
| `#` takes effect _after_ the expansions are parsed. |
Owner
There was a problem hiding this comment.
That sounds incorrect to me, decl str foo 'foo # bar'; echo %opt{foo} does echo foo # bar, or maybe you meant something different with "after the expansions are parsed"
Author
There was a problem hiding this comment.
I meant that it's only executed, if it is, only after the expansions are parsed. But reading this again and after your observation, it's clearly poorly worded.
How about:
The parsing of strings and expansions happens before # is evaluated as commenting out the rest of the line, hence its meaning might change according to command-parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way of specifying that, so corrections are welcome.