Fix unbalanced duration value in Temporal example#43709
Merged
Conversation
I suspect this is just the result of an error when copying an example from one of the other `Duration` accessors.
github-actions
bot
added
Content:JS
Josh-Cena
requested review from
Josh-Cena
and removed request for
sideshowbarker
Contributor
|
Preview URLs (1 page) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the resultant values listed in the examples of accessing the
minutesproperty of an unbalancedDuration. It will be30, not1, when taking theminutesvalue of an unbalancedDurationinitialised from{ hours: 1, minutes: 30 }.Motivation
This was the first of the
Durationaccessors I read about and I stared at the example for quite a while trying to work out where the1would have come from!Additional details
Verified that this is now the correct value by running the expressions in Chrome's console.