Fix HotelCore.Web compilation issues

[Copilot]

HotelCore.Web fails to compile due to conflicting C#/VB.NET files, class name mismatches, and incorrect connection string configuration.

Changes

• Remove conflicting C# files: Delete RouteConfig.cs (auto-generated by Microsoft.AspNet.FriendlyUrls), remove ViewSwitcher references from vbproj
• Fix Global.asax.vb: Register routes and bundles at startup

  Sub Application_Start(sender As Object, e As EventArgs)
      RouteConfig.RegisterRoutes(RouteTable.Routes)
      BundleConfig.RegisterBundles(BundleTable.Bundles)
  End Sub

• Fix Site.Master class mismatch: Rename Site1 → SiteMaster, update Inherits directive to HotelCore.Web.SiteMaster
• Fix connection string: Change name from HotelCoreDB to HotelCore (matches DAL SqlHelper), use portable .\SQLEXPRESS instead of hardcoded server name
• Update README.md: Correct connection string example and add SQL Server instance note

Original prompt

Overview

This is a critical fix for an interview demo project. The HotelCore.Web project has several issues that prevent it from compiling and running correctly. All fixes must be applied ONLY to the HotelCore.Web project - do NOT modify HotelCore.BLL or HotelCore.DAL.

Issues to Fix in HotelCore.Web

1. Remove C# Files (Auto-generated by Microsoft.AspNet.FriendlyUrls)

Delete these C# files that conflict with the VB.NET project:

• HotelCore.Web/App_Start/RouteConfig.cs - DELETE this file (keep RouteConfig.vb)
• HotelCore.Web/ViewSwitcher.ascx - DELETE
• HotelCore.Web/ViewSwitcher.ascx.cs - DELETE
• HotelCore.Web/ViewSwitcher.ascx.designer.cs - DELETE

2. Update HotelCore.Web.vbproj

Remove references to the deleted C# files from the project file. Remove these lines:

• <Content Include="App_Start\RouteConfig.cs" />
• <Content Include="ViewSwitcher.ascx" />
• <Content Include="ViewSwitcher.ascx.cs" />
• <Content Include="ViewSwitcher.ascx.designer.cs" />

3. Fix Global.asax.vb

The Global.asax.vb is not registering routes or bundles. Update it to:

Imports System.Web.Optimization
Imports System.Web.Routing

Public Class Global_asax
    Inherits HttpApplication

    Sub Application_Start(sender As Object, e As EventArgs)
        RouteConfig.RegisterRoutes(RouteTable.Routes)
        BundleConfig.RegisterBundles(BundleTable.Bundles)
    End Sub
End Class

4. Fix Site.Master.vb Class Name Mismatch

The Site.Master file has Inherits="HotelCore.Web.Site.Master" but the code-behind class is named Site1.

Fix HotelCore.Web/Shared/Site.Master.vb - rename class from Site1 to SiteMaster:

Imports System.Web.Security

Public Class SiteMaster
    Inherits System.Web.UI.MasterPage

    Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load

    End Sub

    Protected Sub lnkLogout_Click(sender As Object, e As EventArgs)
        Session.Clear()
        Session.Abandon()
        FormsAuthentication.SignOut()
        Response.Redirect("~/Default.aspx")
    End Sub

    Protected Sub btnSubscribe_Click(sender As Object, e As EventArgs)
        Dim email As String = txtNewsletter.Text.Trim()
        
        If Not String.IsNullOrEmpty(email) Then
            Try
                Dim addr = New System.Net.Mail.MailAddress(email)
                If addr.Address <> email Then
                    ScriptManager.RegisterStartupScript(Me, Me.GetType(), "NewsletterError", "alert('Please enter a valid email address.');", True)
                    Return
                End If
            Catch
                ScriptManager.RegisterStartupScript(Me, Me.GetType(), "NewsletterError", "alert('Please enter a valid email address.');", True)
                Return
            End Try
            
            txtNewsletter.Text = ""
            ScriptManager.RegisterStartupScript(Me, Me.GetType(), "NewsletterSuccess", "alert('Thank you for subscribing!');", True)
        End If
    End Sub

End Class

Also fix HotelCore.Web/Shared/Site.Master - change the Inherits directive:

<%@ Master Language="VB" AutoEventWireup="false" CodeBehind="Site.Master.vb" Inherits="HotelCore.Web.SiteMaster" %>

5. Fix Web.config Connection String Name

The SqlHelper.vb in DAL uses "HotelCore" but Web.config has "HotelCoreDB". Since we can't modify DAL, update Web.config to add another connection string with name "HotelCore" OR change the existing one's name:

Change in HotelCore.Web/Web.config:

<connectionStrings>
    <add name="HotelCore" connectionString="Data Source=.\SQLEXPRESS;Initial Catalog=HotelCore;Integrated Security=True;Encrypt=False" providerName="System.Data.SqlClient" />
</connectionStrings>

Note: Change NAYANWINDOWS\SQLEXPRESS to .\SQLEXPRESS for portability (interviewer can use their own SQL Server instance easily).

6. Clean Up RouteConfig.vb

Remove unnecessary comments and make it clean and professional:

Imports System.Web.Routing
Imports Microsoft.AspNet.FriendlyUrls

Public Class RouteConfig
    Public Shared Sub RegisterRoutes(ByVal routes As RouteCollection)
        routes.EnableFriendlyUrls()

        routes.MapPageRoute("Home", "", "~/Default.aspx")
        routes.MapPageRoute("Facilities", "facilities", "~/Facilities.aspx")
        routes.MapPageRoute("Contact", "contact", "~/Contact.aspx")
        routes.MapPageRoute("RoomSearch", "rooms", "~/Booking/Search.aspx")
        routes.MapPageRoute("RoomDetails", "room/{id}", "~/Booking/RoomDetails.aspx")
        routes.MapPageRoute("Checkout", "checkout", "~/Booking/Checkout.aspx")
        routes.MapPageRoute("Confirmation", "confirmation/{id}", "~/Booking/Confirmation.aspx")
        routes.MapPageRoute("Login", "login", "~/Account/Login.aspx")
        routes.MapPageRoute("Register", "register", "~/Account/Register.aspx")
        routes.MapPageRoute("Profile", "profile", "~/Account/Profile.aspx")
        routes.MapPageRoute("BookingDetails", "...

</details>

*This pull request was created as a result of the following prompt from Copilot chat.*
> ## Overview
> This is a critical fix for an interview demo project. The HotelCore.Web project has several issues that prevent it from compiling and running correctly. All fixes must be applied ONLY to the HotelCore.Web project - do NOT modify HotelCore.BLL or HotelCore.DAL.
> 
> ## Issues to Fix in HotelCore.Web
> 
> ### 1. Remove C# Files (Auto-generated by Microsoft.AspNet.FriendlyUrls)
> Delete these C# files that conflict with the VB.NET project:
> - `HotelCore.Web/App_Start/RouteConfig.cs` - DELETE this file (keep RouteConfig.vb)
> - `HotelCore.Web/ViewSwitcher.ascx` - DELETE
> - `HotelCore.Web/ViewSwitcher.ascx.cs` - DELETE  
> - `HotelCore.Web/ViewSwitcher.ascx.designer.cs` - DELETE
> 
> ### 2. Update HotelCore.Web.vbproj
> Remove references to the deleted C# files from the project file. Remove these lines:
> - `<Content Include="App_Start\RouteConfig.cs" />`
> - `<Content Include="ViewSwitcher.ascx" />`
> - `<Content Include="ViewSwitcher.ascx.cs" />`
> - `<Content Include="ViewSwitcher.ascx.designer.cs" />`
> 
> ### 3. Fix Global.asax.vb
> The Global.asax.vb is not registering routes or bundles. Update it to:
> 
> ```vb
> Imports System.Web.Optimization
> Imports System.Web.Routing
> 
> Public Class Global_asax
>     Inherits HttpApplication
> 
>     Sub Application_Start(sender As Object, e As EventArgs)
>         RouteConfig.RegisterRoutes(RouteTable.Routes)
>         BundleConfig.RegisterBundles(BundleTable.Bundles)
>     End Sub
> End Class
> ```
> 
> ### 4. Fix Site.Master.vb Class Name Mismatch
> The Site.Master file has `Inherits="HotelCore.Web.Site.Master"` but the code-behind class is named `Site1`. 
> 
> Fix `HotelCore.Web/Shared/Site.Master.vb` - rename class from `Site1` to `SiteMaster`:
> 
> ```vb
> Imports System.Web.Security
> 
> Public Class SiteMaster
>     Inherits System.Web.UI.MasterPage
> 
>     Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load
> 
>     End Sub
> 
>     Protected Sub lnkLogout_Click(sender As Object, e As EventArgs)
>         Session.Clear()
>         Session.Abandon()
>         FormsAuthentication.SignOut()
>         Response.Redirect("~/Default.aspx")
>     End Sub
> 
>     Protected Sub btnSubscribe_Click(sender As Object, e As EventArgs)
>         Dim email As String = txtNewsletter.Text.Trim()
>         
>         If Not String.IsNullOrEmpty(email) Then
>             Try
>                 Dim addr = New System.Net.Mail.MailAddress(email)
>                 If addr.Address <> email Then
>                     ScriptManager.RegisterStartupScript(Me, Me.GetType(), "NewsletterError", "alert('Please enter a valid email address.');", True)
>                     Return
>                 End If
>             Catch
>                 ScriptManager.RegisterStartupScript(Me, Me.GetType(), "NewsletterError", "alert('Please enter a valid email address.');", True)
>                 Return
>             End Try
>             
>             txtNewsletter.Text = ""
>             ScriptManager.RegisterStartupScript(Me, Me.GetType(), "NewsletterSuccess", "alert('Thank you for subscribing!');", True)
>         End If
>     End Sub
> 
> End Class
> ```
> 
> Also fix `HotelCore.Web/Shared/Site.Master` - change the Inherits directive:
> ```
> <%@ Master Language="VB" AutoEventWireup="false" CodeBehind="Site.Master.vb" Inherits="HotelCore.Web.SiteMaster" %>
> ```
> 
> ### 5. Fix Web.config Connection String Name
> The SqlHelper.vb in DAL uses `"HotelCore"` but Web.config has `"HotelCoreDB"`. Since we can't modify DAL, update Web.config to add another connection string with name "HotelCore" OR change the existing one's name:
> 
> Change in `HotelCore.Web/Web.config`:
> ```xml
> <connectionStrings>
>     <add name="HotelCore" connectionString="Data Source=.\SQLEXPRESS;Initial Catalog=HotelCore;Integrated Security=True;Encrypt=False" providerName="System.Data.SqlClient" />
> </connectionStrings>
> ```
> 
> Note: Change `NAYANWINDOWS\SQLEXPRESS` to `.\SQLEXPRESS` for portability (interviewer can use their own SQL Server instance easily).
> 
> ### 6. Clean Up RouteConfig.vb
> Remove unnecessary comments and make it clean and professional:
> 
> ```vb
> Imports System.Web.Routing
> Imports Microsoft.AspNet.FriendlyUrls
> 
> Public Class RouteConfig
>     Public Shared Sub RegisterRoutes(ByVal routes As RouteCollection)
>         routes.EnableFriendlyUrls()
> 
>         routes.MapPageRoute("Home", "", "~/Default.aspx")
>         routes.MapPageRoute("Facilities", "facilities", "~/Facilities.aspx")
>         routes.MapPageRoute("Contact", "contact", "~/Contact.aspx")
>         routes.MapPageRoute("RoomSearch", "rooms", "~/Booking/Search.aspx")
>         routes.MapPageRoute("RoomDetails", "room/{id}", "~/Booking/RoomDetails.aspx")
>         routes.MapPageRoute("Checkout", "checkout", "~/Booking/Checkout.aspx")
>         routes.MapPageRoute("Confirmation", "confirmation/{id}", "~/Booking/Confirmation.aspx")
>         routes.MapPageRoute("Login", "login", "~/Account/Login.aspx")
>         routes.MapPageRoute("Register", "register", "~/Account/Register.aspx")
>         routes.MapPageRoute("Profile", "profile", "~/Account/Profile.aspx")
>         routes.MapPageRoute("BookingDetails", "booking/{id}", "~/Account/BookingDetails.aspx")
>         routes.MapPageRoute("AdminDashboard", "admin", "~/Admin/Dashboard.aspx")
>         routes.MapPageRoute("AdminBookings", "admin/bookings", "~/Admin/Bookings.aspx")
>         routes.MapPageRoute("AdminRooms", "admin/rooms", "~/Admin/Rooms.aspx")
>     End Sub
> End Class
> ```
> 
> ### 7. Update README.md
> Update the connection string example to be more generic and interviewer-friendly:
> 
> In the "Configure Connection String" section, update to:
> ```xml
> <connectionStrings>
>     <add name="HotelCore" 
>          connectionString="Data Source=.\SQLEXPRESS;Initial Catalog=HotelCore;Integrated Security=True;Encrypt=False" 
>          providerName="System.Data.SqlClient" />
> </connectionStrings>
> ```
> 
> Also add a note: "Replace `.\SQLEXPRESS` with your SQL Server instance name if different."
> 
> ## Important Notes
> - DO NOT modify any files in HotelCore.BLL or HotelCore.DAL
> - Remove all unnecessary comments from code files
> - Ensure all files are clean and professional
> - The project must compile and run without errors after these fixes
> - This is for an interview demo - code quality matters

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for you](https://github.com/mdnayanmia31/HotelCore/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

[mdnayanmia31]

@copilot Could you kindly tell me how, should I merge your code with main?

[Copilot]

@copilot Could you kindly tell me how, should I merge your code with main?

To merge this PR with main, you can use one of these methods:

Option 1: Via GitHub UI (Recommended)

1. Go to this PR on GitHub
2. Click the green "Merge pull request" button at the bottom
3. Choose your preferred merge strategy (Create a merge commit, Squash and merge, or Rebase and merge)
4. Click "Confirm merge"

Option 2: Via Command Line

git checkout main
git pull origin main
git merge copilot/fix-hotelcore-web-issues
git push origin main

After merging, you can delete the branch if no longer needed.