Remove useless window.setTimeout call - #3
Open
SamB wants to merge 1 commit into
Open
Conversation
Well, the code has been passing the *value* of `sendMetaInfoToExtension()` to `window.setTimeout` for the past 5 years. That value is `undefined`, which evidently gets subjected to an [approximation of `eval`][1]. There don't seem to be any observable effects of this other than triggering a CSP violation when the page's `script-src` policy doesn't include `unsafe-eval`, so just call `sendMetaInfoToExtension()` and don't set the timeout. [1]: https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timers:report-the-exception
Author
|
Hmm. Perhaps I should have been more explicit about the logspam? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, the code has been passing the value of
sendMetaInfoToExtension()towindow.setTimeoutfor the past 5 years. That value isundefined, which evidently gets subjected to an [approximation ofeval][1]. There don't seem to be any observable effects of this other than triggering a CSP violation when the page'sscript-srcpolicy doesn't includeunsafe-eval, so just callsendMetaInfoToExtension()and don't set the timeout.