Follow upstream drift, and stop the drift check crying wolf - #15
Merged
Conversation
The scheduled upstream-drift job has failed on all three of its runs. Only one
of those was news:
* cucumber/gherkin dropped the trailing space from the Texas dialect's `rule`
keyword ("Rule " -> "Rule"). It matters: GherkinParser matches block
keywords as "<keyword>:", so with the trailing space a `Rule:` line in a
Texas feature was never recognised as a rule. Regenerating the dialect
table fixes that.
The rest was noise. Each corpus tool cloned upstream shallowly and pinned
`rev-parse HEAD`, so the recorded Source line moved for any commit to those
repositories -- a README typo in the monorepo re-pinned all 50+12 Gherkin
fixtures -- and the drift check reported news every week the fixtures had not
moved. They now pin the last commit that touched `testdata/`, which is the
provenance the line was always meant to carry. That needs a path-scoped log, so
the clone is blobless rather than shallow; it stays cheap (~8 MB, under three
seconds for cucumber/gherkin) and the whole regeneration still runs in under
ten seconds.
Re-pinning to the last testdata commit moves all three Source lines once more,
with byte-identical corpora underneath.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012FHrC4wQaCMKaHLZcnFiS5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled upstream-drift job has failed on all three of its runs. Only one
of those was news:
rulekeyword ("Rule " -> "Rule"). It matters: GherkinParser matches block
keywords as ":", so with the trailing space a
Rule:line in aTexas feature was never recognised as a rule. Regenerating the dialect
table fixes that.
The rest was noise. Each corpus tool cloned upstream shallowly and pinned
rev-parse HEAD, so the recorded Source line moved for any commit to thoserepositories -- a README typo in the monorepo re-pinned all 50+12 Gherkin
fixtures -- and the drift check reported news every week the fixtures had not
moved. They now pin the last commit that touched
testdata/, which is theprovenance the line was always meant to carry. That needs a path-scoped log, so
the clone is blobless rather than shallow; it stays cheap (~8 MB, under three
seconds for cucumber/gherkin) and the whole regeneration still runs in under
ten seconds.
Re-pinning to the last testdata commit moves all three Source lines once more,
with byte-identical corpora underneath.