test(e2e): fix Cypress config for Node.JS v20.19.0#6410
Merged
ashishjain0512 merged 1 commit intomermaid-js:developfrom Mar 25, 2025
Merged
Conversation
Node.JS v20.19.0 breaks `import '@cypress/code-coverage/task'` in the `cypress.config.ts` for some reason (this is probably due to the new `experimental-require-module` feature that is enabled by default in Node.JS v20.19.0). As a work-around, we can change this to `@cypress/code-coverage/task.js`. See: cypress-io/code-coverage#940 See: https://nodejs.org/en/blog/release/v20.19.0
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6410 +/- ##
=======================================
Coverage 3.86% 3.86%
=======================================
Files 412 411 -1
Lines 43189 43178 -11
Branches 664 664
=======================================
Hits 1670 1670
+ Misses 41519 41508 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
ashishjain0512
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
Node.JS v20.19.0 breaks
import '@cypress/code-coverage/task'in thecypress.config.tsfor some reason (this is probably due to the newexperimental-require-modulefeature that is enabled by default in Node.JS v20.19.0).As a work-around, we can change this to
@cypress/code-coverage/task.jsandcypress-image-snapshot/plugin.js'.See: cypress-io/code-coverage#940
See: https://nodejs.org/en/blog/release/v20.19.0
📏 Design Decisions
The reason why we don't need to update
@argos-ci/cypress/taskis because they've set theirexportsin thepackage.jsonfile:https://github.com/argos-ci/argos-javascript/blob/af931a704908a48f49f375f92f23924a39792c7e/packages/cypress/package.json#L30-L43
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.