Suppress clause delimiter via i18n, not code - #538
Merged
Conversation
Set clause_delimiter to "" in the ribose i18n dictionary and drop the now-redundant BaseConvert#clausedelim override. The delimiter is applied in the presentation-XML stage (single source of truth), so PDF/FO output honours it too — fixing the period that previously appeared only in the presentation-consuming outputs. Prefers YAML config over inheritor code. Requires isodoc >= 3.7.2 (configurable clause_delimiter, metanorma/isodoc#838). Refs metanorma/metanorma-pdfa#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs metanorma/metanorma-pdfa#74
Ribose intended to suppress the terminal clause-number delimiter (
clausedelim→""inBaseConvert), but that override only reached the final-format converters (Html/Pdf/Word);Ribose::PresentationXMLConvertfell through to the base".", so the period was baked into the presentation XML that the FO/PDF path consumes (metanorma-pdfa#74).Fix via i18n (single source of truth, no inheritor code): set
clause_delimiter: ''in the ribose i18n dictionary and drop the now-redundantBaseConvert#clausedelimoverride. The presentation stage honours it, so PDF/FO drops the period too, and downstream users can retune it without XSL tricks.Draft / gated: requires the configurable
clause_delimiterfrom metanorma/isodoc#838 (isodoc 3.7.2); inert until that ships.🤖