feat: register WordprocessingML substitutions for omml types - #29
Open
ronaldtse wants to merge 1 commit into
Open
feat: register WordprocessingML substitutions for omml types#29ronaldtse wants to merge 1 commit into
ronaldtse wants to merge 1 commit into
Conversation
OmmlIntegration module registers Uniword's WordprocessingML classes as substitutions for omml gem's minimal stubs via Register#register_global_type_substitution. Current substitutions: - Omml::Models::CTBr => Uniword::Wordprocessingml::Break This establishes the integration point architecture: omml owns the math schema, Uniword owns the WordprocessingML schema, and the two meet through register substitution rather than duplicate model definitions. Additional substitutions (CTRPr, CTFonts, etc.) can be added to the SUBSTITUTIONS hash as API compatibility is verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OmmlIntegrationmodule registers Uniword's WordprocessingML classes as substitutions for omml gem's minimal stubs viaRegister#register_global_type_substitutionOmml::Models::CTBr => Uniword::Wordprocessingml::BreakContext
Per the architectural principle: omml defines its own minimal WordprocessingML classes (for standalone use); when used inside Uniword, register substitution replaces them with Uniword's richer equivalents. Single source of truth for WordprocessingML types.
Additional substitutions (CTRPr, CTFonts, etc.) can be added to the
SUBSTITUTIONShash as API compatibility is verified.Test plan