Github Enterprise has a different API endpoint compared to Free/Pro/teams version#1309
Open
ahmed-wajid wants to merge 4 commits intomher:masterfrom
Open
Github Enterprise has a different API endpoint compared to Free/Pro/teams version#1309ahmed-wajid wants to merge 4 commits intomher:masterfrom
ahmed-wajid wants to merge 4 commits intomher:masterfrom
Conversation
Contributor
Author
|
@mehr Could this be merged sometime soon? we have been living with basic auth meanwhile :( |
|
Can we merge this change? We would like to have this feature too. Thanks |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GitHub Enterprise by implementing dynamic API endpoint selection based on the OAuth domain. The change allows Flower to work with both GitHub.com and GitHub Enterprise instances by using different API URL patterns for each.
- Introduces conditional logic to set the correct API endpoint based on the OAuth domain
- Updates documentation to explain GitHub Enterprise configuration
- Replaces hardcoded API URL with a configurable variable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flower/views/auth.py | Adds conditional logic to set appropriate API endpoint for GitHub.com vs GitHub Enterprise domains |
| docs/auth.rst | Documents the FLOWER_GITHUB_OAUTH_DOMAIN environment variable for GitHub Enterprise setup |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@auvipy Could you please review and approve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an if conditional to switch the
_OAUTH_API_URLif using a custom domain other thangithub.com.Fixes: #1308