Skip to content

test: add unicode press() regression tests for umlaut and CJK characters#139

Open
Kartalops wants to merge 1 commit into
mherrmann:masterfrom
Kartalops:contrib/helium/unicode-press-test
Open

test: add unicode press() regression tests for umlaut and CJK characters#139
Kartalops wants to merge 1 commit into
mherrmann:masterfrom
Kartalops:contrib/helium/unicode-press-test

Conversation

@Kartalops

Copy link
Copy Markdown

Summary

  • Add 3 regression tests for press() with unicode characters (German umlauts, CJK, SHIFT+unicode)
  • Test_press.py previously only covered ASCII characters (a-z, A-Z)

Problem

tests/api/test_press.py had only ASCII test coverage. No test verified that press() correctly handles unicode input via Selenium's send_keys(). This is a regression gap — unicode support exists in the implementation but has no test.

Solution

Add 3 targeted regression tests:

  • test_press_unicode_german_umlaut: verify 'ü' works
  • test_press_unicode_chinese: verify '中' works
  • test_press_unicode_combined: verify SHIFT+'ü' doesn't throw

Tests

# Chrome (default)
python setup.py test

# Firefox
TEST_BROWSER=firefox python setup.py test

All tests run against test_write.html (Autofocus text field).

Risk / Compatibility

  • Risk: LOW — test-only change, no production code modified
  • Affects: tests only (test_press.py)
  • No public API changes
  • No new dependencies

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants