Skip to content

fix: code quality improvements vet target, bug fixes, and typo corrections - #284

Open
patilpratik1905 wants to merge 1 commit into
microcks:masterfrom
patilpratik1905:small_fix/typos_bug_addVet
Open

fix: code quality improvements vet target, bug fixes, and typo corrections#284
patilpratik1905 wants to merge 1 commit into
microcks:masterfrom
patilpratik1905:small_fix/typos_bug_addVet

Conversation

@patilpratik1905

Copy link
Copy Markdown

Description

Changes

1. Add vet target to Makefile

Added make vet target that runs go vet ./... across all packages.
Enables standardized static analysis locally and in CI pipelines.

2. Fix fmt.Errorf result not used (pkg/watcher/executor.go)

fmt.Errorf(...) was called but its return value was discarded, silently
swallowing the error. Replaced with fmt.Printf(...) so the error is
actually printed to output.

3. Fix DownloadArtifact reading wrong body (pkg/connectors/microcks_client.go)

io.ReadAll(req.Body) was reading the request body instead of the response
body after the HTTP call completed. This caused the function to always return
empty data. Fixed to io.ReadAll(resp.Body).

4. Fix function name typo (pkg/connectors/microcks_client.go)

Renamed ensureValieOAuth2ContextensureValidOAuth2Context.
Updated both the function definition and its call site.

Testing

  • make vet now passes with no errors

Related issue(s)

NA

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

👋 @patilpratik1905

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

…; add vet target to Makefile

Signed-off-by: Pratik Patil <pratikgpatil1905@gmail.com>
@patilpratik1905
patilpratik1905 force-pushed the small_fix/typos_bug_addVet branch from ab6f5a1 to 398bcce Compare May 5, 2026 09:26
@Caesarsage

Copy link
Copy Markdown
Contributor

The typos are covered by #300 and CI now runs go test — but the make vet idea is still good and aligns with #355. Suggest re-scoping this PR to just the vet target (or folding it into a CI-gates PR alongside staticcheck).

@Harsh4902

Copy link
Copy Markdown
Member

Thanks @Caesarsage for your review. @patilpratik1905 I'm keeping this PR open and waiting for your update.

@Harsh4902 Harsh4902 added kind/enhancement New feature or request keep-open Explicitily keep open component/build labels Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/build keep-open Explicitily keep open kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants