Skip to content

fix: preserve mainArtifact default on parse failure in import and import-url #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdeshDeshmukh wants to merge 3 commits into from
+171 −22
Closed

fix: preserve mainArtifact default on parse failure in import and import-url #460

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c779ac
fix: preserve mainArtifact default on parse failure in import and imp…
AdeshDeshmukh Jun 17, 2026
69e2cd5
fix(import): use LastIndex to safely handle paths with colons
AdeshDeshmukh Jun 21, 2026
c570f43
fix: preserve mainArtifact default on parse failure and fix URL port …
AdeshDeshmukh Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cmd/import.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,16 @@ func NewImportCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command
sepSpecificationFiles := strings.Split(specificationFiles, ",")
for _, f := range sepSpecificationFiles {
mainArtifact := true
var err error

// Check if mainArtifact flag is provided.
if strings.Contains(f, ":") {
pathAndMainArtifact := strings.Split(f, ":")
f = pathAndMainArtifact[0]
mainArtifact, err = strconv.ParseBool(pathAndMainArtifact[1])
if err != nil {
fmt.Printf("Cannot parse '%s' as Bool, default to true\n", pathAndMainArtifact[1])
lastColon := strings.LastIndex(f, ":")
boolPart := f[lastColon+1:]
f = f[:lastColon]
if val, parseErr := strconv.ParseBool(boolPart); parseErr != nil {
fmt.Printf("Cannot parse '%s' as Bool, default to true\n", boolPart)
} else {
mainArtifact = val
}
}
Comment on lines 124 to 133

Expand Down
5 changes: 3 additions & 2 deletions cmd/importURL.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ func NewImportURLCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
if n > 2 {
val, err := strconv.ParseBool(urlAndMainAtrifactAndSecretName[2])
if err != nil {
fmt.Println(err)
fmt.Printf("Cannot parse '%s' as Bool, default to true\n", urlAndMainAtrifactAndSecretName[2])
} else {
mainArtifact = val
}

@Vaishnav88sk Vaishnav88sk Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve

mainArtifact = val
}
if n > 3 {
secret = urlAndMainAtrifactAndSecretName[3]
Expand Down