Fix Prometheus registry metadata for prom-client-java upgrades#7460
Closed
zeitlinger wants to merge 8 commits into
Closed
Fix Prometheus registry metadata for prom-client-java upgrades#7460zeitlinger wants to merge 8 commits into
zeitlinger wants to merge 8 commits into
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
Author
|
I made it ready for review - let me know what you think. |
Contributor
Author
|
Superseded by #7487, which switches Micrometer to the new typed family descriptor API from prometheus/client_java#2114. Closing this older prototype so review can focus on the end-state design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests added on the Prometheus side to support repeated
prom-client-javaupgrade work exposed this issue in Micrometer.
In this case, the compatibility testing did not only show a prom-side problem.
It also showed a necessary Micrometer-side change in the
prometheusmetricsadapter.
This draft contains the change we currently believe Micrometer will need when
moving to the newer
prom-client-javarelease line.What this changes
MicrometerCollectorPrometheusMeterRegistrywith theMetricSnapshotmetadata used at scrape timescrape path will actually emit
Why this is draft
We'd like feedback from Micrometer maintainers on whether this is the right
Micrometer-side fix.
Context
feat: add micrometer compatibility workflow zeitlinger/client_java#1
fix: restore legacy suffix compatibility prometheus/client_java#2100
the Prometheus-side release notes/docs, so that is being clarified here:
docs: clarify downstream adapter validation requirements prometheus/client_java#2101