Pageable/start from 1

[alexsimpson440dev]

What this does

• Adds startFromPageOne config property that allows users to enter 1 for the page number and get the first page back
• This is done by shifting the page number in the PageableRequestArgumentBinder by one if that property is set to true

Why is this needed

• This functionality is currently in spring here: https://github.com/spring-projects/spring-data-commons/blob/0e5e869cbf987155590b7e04717f5e965d90d49b/src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverSupport.java#L283 which does the same thing using the oneIndexedParameters property.
• API standards for git, Target, and I am sure other corporations start from page one. Here is a snippet from gits page:
  This makes sense, since by default, all paginated queries start at page 1. - https://docs.github.com/en/rest/guides/traversing-with-pagination

I am sure there are better ways to implement this, but this is similar to how spring has it implemented.

Also I noticed the docs for configuration properties are here: https://micronaut-projects.github.io/micronaut-data/latest/guide/configurationreference.html#io.micronaut.data.r2dbc.config.DataR2dbcConfiguration which doesn't seem to be linked to micronaut-data. Let me know if you would like me to update these docs if this does move forward.

[dstepanov]

Looks fine to me, you might want to throw an exception if somebody sends 0 as the page number.

[graemerocher]

I'm not sure this change is enough. The return value of

micronaut-data/data-model/src/main/java/io/micronaut/data/model/Pageable.java

Line 57 in bbc603c

int getNumber();

would also need to be shifted whenever an instance of Page is returned would it not?

[dstepanov]

It's only problematic if you use Page directly in the response, if you have a custom one it's fine.

[BrianEstrada]

Bumping, any updates on this? would be super cool to have this as a configurable

[alexsimpson440dev]

@BrianEstrada I haven't done anything as of recently but I was researching a way to do this without shifting the page number down 1. I remember there might be a way to change what is returned via offsets in the pageable interface but Its been a while.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}