Skip to content

move the BuildInitialize hook to after determine build project #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Freddy Kristiansen (freddydk) wants to merge 6 commits into
base: main
Choose a base branch
from
Open

move the BuildInitialize hook to after determine build project #2265

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec5e182
move the BuildInitialize hook to after determine build project
freddydk May 27, 2026
d816c80
use boolean instead of string
freddydk May 27, 2026
0a243a3
Add BuildCleanup hook
freddydk May 27, 2026
383acf0
Merge branch 'main' into main
freddydk May 27, 2026
ff6f45c
Merge branch 'main' into main
freddydk Jul 5, 2026
a2a8cbe
Merge branch 'main' into main
spetersenms Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions Templates/AppSource App/.github/workflows/_BuildALGoProject.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,6 @@ jobs:
buildMode: ${{ inputs.buildMode }}
get: useCompilerFolder,workspaceCompilation,keyVaultCodesignCertificateName,doNotSignApps,doNotRunTests,doNotRunBcptTests,doNotRunpageScriptingTests,artifact,generateDependencyArtifact,trustedSigning,useGitSubmodules,trackALAlertsInGitHub,skipUpgrade

- name: Run Build Initialize hook
if: hashFiles(format('{0}/.AL-Go/BuildInitialize.ps1', inputs.project)) != ''
uses: microsoft/AL-Go-Actions/RunHook@main
with:
shell: ${{ inputs.shell }}
project: ${{ inputs.project }}
hookName: BuildInitialize

- name: Determine whether to build project
id: DetermineBuildProject
uses: microsoft/AL-Go-Actions/DetermineBuildProject@main
Expand All @@ -128,6 +120,19 @@ jobs:
project: ${{ inputs.project }}
baselineWorkflowRunId: ${{ inputs.baselineWorkflowRunId }}

- name: Run Build Initialize hook
if: hashFiles(format('{0}/.AL-Go/BuildInitialize.ps1', inputs.project)) != ''
Comment thread
freddydk marked this conversation as resolved.
uses: microsoft/AL-Go-Actions/RunHook@main
with:
shell: ${{ inputs.shell }}
project: ${{ inputs.project }}
hookName: BuildInitialize
parametersJson: |
{
"buildMode": "${{ inputs.buildMode }}",

@aholstrup1 Alexander Holstrup (aholstrup1) May 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if buildmode should just be a standard parameter like project is

@freddydk Freddy Kristiansen (freddydk) May 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on whether hooks will be available in non-build workflows as well, but then project maybe shouldn't be a standard parameter?
Let me know what you conclude?

"buildIt": ${{ steps.DetermineBuildProject.outputs.BuildIt == 'True' }}

@aholstrup1 Alexander Holstrup (aholstrup1) May 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than passing BuildIt as a parameter, wouldn't it make more sense to just skip the hook altogether if BuildIt is false? Not sure what a hook would do in a job that doesnt build anyway.

What do you think?

@freddydk Freddy Kristiansen (freddydk) May 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it actually will invoke the _BuildALGoProject (to copy the files), but it would be OK for my scenario.
I also added a Cleanup hook - with these two hooks, I can integrate Fkh to AL-Go and not need anything but that.
Obviously, I would copy some overrides to the .AL-Go folder during build, but I could modify those when you guys modify the build process and keep all changes centralized.

This is how my BuildInitialize and BuildCleanup looks:

Param(
    [Hashtable] $parameters
)

# AL-Go Hook

$buildIt = $parameters.buildIt

if (-not $buildIt) {
    Write-Host "BuildIt is false, no need to copy fkh scripts"
    return
}

$ENV:FKH_BACKEND_URL = "https://fkh-freddydk-backend.azurewebsites.net/api"
$ENV:FKH_TIMEZONE = "Europe/Copenhagen"

Write-Host "Install Freddy's Kubernetes Helper & Business Central Development Tools"
dotnet tool install -g fkh --prerelease
dotnet tool install -g Microsoft.Dynamics.BusinessCentral.Development.Tools

fkh applyALGoOverrides --output $PSScriptRoot

and Cleanup:

Param(
    [Hashtable] $parameters
)

# AL-Go Hook

$project = $parameters.project
$buildMode = $parameters.buildMode
$buildIt = $parameters.buildIt

if (-not $buildIt) {
    Write-Host "BuildIt is false, no need to remove container"
    return
}

$ENV:FKH_BACKEND_URL = "https://fkh-freddydk-backend.azurewebsites.net/api"
$ENV:FKH_TIMEZONE = "Europe/Copenhagen"

$parts = "$ENV:GITHUB_REPOSITORY". Split('/')
$containerName = "$($parts[0])-$($parts[1])-$($project)-$($buildMode)-$($ENV:GITHUB_RUN_ID)".ToLower() -replace "[^a-z0-9\-]"

fkh RemoveContainer --name $containerName --useOIDC

I can easily modify the PR to skip the hooks if buildIt is false - I am not going to use that.

}

- name: Read secrets
id: ReadSecrets
if: steps.DetermineBuildProject.outputs.BuildIt == 'True'
Expand Down
21 changes: 13 additions & 8 deletions Templates/Per Tenant Extension/.github/workflows/_BuildALGoProject.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,6 @@ jobs:
buildMode: ${{ inputs.buildMode }}
get: useCompilerFolder,workspaceCompilation,keyVaultCodesignCertificateName,doNotSignApps,doNotRunTests,doNotRunBcptTests,doNotRunpageScriptingTests,artifact,generateDependencyArtifact,trustedSigning,useGitSubmodules,trackALAlertsInGitHub,skipUpgrade

- name: Run Build Initialize hook
if: hashFiles(format('{0}/.AL-Go/BuildInitialize.ps1', inputs.project)) != ''
uses: microsoft/AL-Go-Actions/RunHook@main
with:
shell: ${{ inputs.shell }}
project: ${{ inputs.project }}
hookName: BuildInitialize

- name: Determine whether to build project
id: DetermineBuildProject
uses: microsoft/AL-Go-Actions/DetermineBuildProject@main
Expand All @@ -128,6 +120,19 @@ jobs:
project: ${{ inputs.project }}
baselineWorkflowRunId: ${{ inputs.baselineWorkflowRunId }}

- name: Run Build Initialize hook
if: hashFiles(format('{0}/.AL-Go/BuildInitialize.ps1', inputs.project)) != ''
Comment thread
freddydk marked this conversation as resolved.
uses: microsoft/AL-Go-Actions/RunHook@main
with:
shell: ${{ inputs.shell }}
project: ${{ inputs.project }}
hookName: BuildInitialize
parametersJson: |
{
"buildMode": "${{ inputs.buildMode }}",
"buildIt": ${{ steps.DetermineBuildProject.outputs.BuildIt == 'True' }}
}

- name: Read secrets
id: ReadSecrets
if: steps.DetermineBuildProject.outputs.BuildIt == 'True'
Expand Down
Loading