-
Notifications
You must be signed in to change notification settings - Fork 201
move the BuildInitialize hook to after determine build project #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
ec5e182
d816c80
0a243a3
383acf0
ff6f45c
a2a8cbe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,14 +111,6 @@ jobs: | |
| buildMode: ${{ inputs.buildMode }} | ||
| get: useCompilerFolder,workspaceCompilation,keyVaultCodesignCertificateName,doNotSignApps,doNotRunTests,doNotRunBcptTests,doNotRunpageScriptingTests,artifact,generateDependencyArtifact,trustedSigning,useGitSubmodules,trackALAlertsInGitHub,skipUpgrade | ||
|
|
||
| - name: Run Build Initialize hook | ||
| if: hashFiles(format('{0}/.AL-Go/BuildInitialize.ps1', inputs.project)) != '' | ||
| uses: microsoft/AL-Go-Actions/RunHook@main | ||
| with: | ||
| shell: ${{ inputs.shell }} | ||
| project: ${{ inputs.project }} | ||
| hookName: BuildInitialize | ||
|
|
||
| - name: Determine whether to build project | ||
| id: DetermineBuildProject | ||
| uses: microsoft/AL-Go-Actions/DetermineBuildProject@main | ||
|
|
@@ -128,6 +120,19 @@ jobs: | |
| project: ${{ inputs.project }} | ||
| baselineWorkflowRunId: ${{ inputs.baselineWorkflowRunId }} | ||
|
|
||
| - name: Run Build Initialize hook | ||
| if: hashFiles(format('{0}/.AL-Go/BuildInitialize.ps1', inputs.project)) != '' | ||
| uses: microsoft/AL-Go-Actions/RunHook@main | ||
| with: | ||
| shell: ${{ inputs.shell }} | ||
| project: ${{ inputs.project }} | ||
| hookName: BuildInitialize | ||
| parametersJson: | | ||
| { | ||
| "buildMode": "${{ inputs.buildMode }}", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm wondering if buildmode should just be a standard parameter like project is
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Depends on whether hooks will be available in non-build workflows as well, but then project maybe shouldn't be a standard parameter? |
||
| "buildIt": "${{ steps.DetermineBuildProject.outputs.BuildIt }}" | ||
|
freddydk marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| - name: Read secrets | ||
| id: ReadSecrets | ||
| if: steps.DetermineBuildProject.outputs.BuildIt == 'True' | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.