Skip to content

Audit and narrow overly broad detection rules with comprehensive test coverage #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from

Fix schema validation: capitalize severity, type, confidence, and sco…

f7c03c2
Select commit
Loading
Failed to load commit list.
Open

Audit and narrow overly broad detection rules with comprehensive test coverage #635

Fix schema validation: capitalize severity, type, confidence, and sco…
f7c03c2
Select commit
Loading
Failed to load commit list.
Azure Pipelines / AppInspector-PR failed Feb 14, 2026 in 11m 21s

Build #1.9.67+26c1ce6edb had test failures

2 errors / 2 warnings

Details

Tests

  • Failed: 12 (1.16%)
  • Passed: 1,023 (98.84%)
  • Other: 0 (0.00%)
  • Total: 1,035

Annotations

Check failure on line 439 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AppInspector-PR

Build log #L439 

Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 444 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AppInspector-PR

Build log #L444 

Dotnet command failed with non-zero exit code on the following projects : [ 'D:\\a\\_work\\1\\s\\AppInspector.Tests\\AppInspector.Tests.csproj' ]

Check failure on line 1 in AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyDefaultRulesAreValidWithNonBacktracking

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AppInspector-PR

AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyDefaultRulesAreValidWithNonBacktracking 

Assert.Equal() Failure: Values differ
Expected: Verified
Actual:   NotVerified
Raw output 
   at AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyDefaultRulesAreValidWithNonBacktracking() in D:\a\_work\1\s\AppInspector.Tests\DefaultRules\TestDefaultRules.cs:line 104
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyNonZeroDefaultRules

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AppInspector-PR

AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyNonZeroDefaultRules 

Assert.True() Failure
Expected: True
Actual:   False
Raw output 
   at AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyNonZeroDefaultRules() in D:\a\_work\1\s\AppInspector.Tests\DefaultRules\TestDefaultRules.cs:line 117
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in AppInspector.Tests.Commands.TestPackRulesCmd.PackEmbeddedRules

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AppInspector-PR

AppInspector.Tests.Commands.TestPackRulesCmd.PackEmbeddedRules 

Microsoft.ApplicationInspector.Common.OpException : Verify rules failed.  See log file for details
Raw output 
   at Microsoft.ApplicationInspector.Commands.PackRulesCommand.GetResult() in D:\a\_work\1\s\AppInspector\Commands\PackRulesCommand.cs:line 109
   at AppInspector.Tests.Commands.TestPackRulesCmd.PackEmbeddedRules() in D:\a\_work\1\s\AppInspector.Tests\Commands\TestPackRulesCmd.cs:line 23
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyDefaultRulesAreValid

See this annotation in the file changed.

@azure-pipelines azure-pipelines / AppInspector-PR

AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyDefaultRulesAreValid 

Assert.Equal() Failure: Values differ
Expected: Verified
Actual:   NotVerified
Raw output 
   at AppInspector.Tests.DefaultRules.TestDefaultRules.VerifyDefaultRulesAreValid() in D:\a\_work\1\s\AppInspector.Tests\DefaultRules\TestDefaultRules.cs:line 59
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
View more details on Azure Pipelines