Skip to content

Obsolete objects and add deprecation notices for PTE upload/install in Extension Management #10046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PooyaKharamesh wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Obsolete objects and add deprecation notices for PTE upload/install in Extension Management #10046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1486ab5
Deprecate in-product extension management pages
PooyaKharamesh Aug 7, 2026
989e660
Limit extension deprecation changes to main pages
PooyaKharamesh Aug 7, 2026
7573751
Add extension management documentation link
PooyaKharamesh Aug 7, 2026
79177cb
Refine deprecation notification link text
PooyaKharamesh Aug 7, 2026
2d7c664
Show extension deprecation notice on-premises
PooyaKharamesh Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/System Application/App/Extension Management/src/ExtensionInstallation.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ using System;
page 2503 "Extension Installation"
{
Extensible = false;
ObsoleteReason = 'Use the Business Central admin center to install and manage extensions.';

@github-actions github-actions Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Upgrade}$

Extension Installation remains part of the non-SaaS install flow: ExtensionMarketplace.Codeunit.al unconditionally instantiates and runs Page "Extension Installation" (via ExtensionInstallationPage.RunModal()), and the same codeunit has explicit non-SaaS handling elsewhere (if not EnvironmentInformation.IsSaaS() then OnOverrideUrl(URL)). Marking the page obsolete with ObsoleteReason = 'Use the Business Central admin center to install and manage extensions.' leaves on-prem consumers of this still-active call path without an actionable replacement.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4

ObsoleteState = Pending;
ObsoleteTag = '29.0';
PageType = Card;
SourceTable = "Extension Installation";
SourceTableTemporary = true;
Expand Down Expand Up @@ -80,4 +83,3 @@ page 2503 "Extension Installation"
end;
}


18 changes: 18 additions & 0 deletions src/System Application/App/Extension Management/src/ExtensionManagement.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ using System.Integration;
page 2500 "Extension Management"
{
Caption = 'Extension Management';
ObsoleteReason = 'Use the Business Central admin center to upload and manage per-tenant extensions.';

@github-actions github-actions Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Upgrade}$

Extension Management still runs an explicit non-SaaS display path (IsOnPremDisplay := not IsMarketplaceEnabled or not IsSaaS), and the new deprecation notification only fires if IsSaaS. The ObsoleteReason ('Use the Business Central admin center to upload and manage per-tenant extensions.') names a replacement (the admin center) that is not available to on-prem/non-SaaS consumers of this page, leaving them without an actionable migration path per the obsoletion guidance. Either name a replacement that covers on-prem users too, or hold off marking the page obsolete until the non-SaaS path has one.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4

ObsoleteState = Pending;
ObsoleteTag = '29.0';
AdditionalSearchTerms = 'app,add-in,customize,plug-in,appsource';
ApplicationArea = All;
DeleteAllowed = false;
Expand Down Expand Up @@ -382,9 +385,21 @@ page 2500 "Extension Management"
ActionsEnabled := false;

HelpActionVisible := false;
ShowExtensionManagementDeprecationNotification();
ShowUninstalledExtensionsNotification();
end;

local procedure ShowExtensionManagementDeprecationNotification()
var
DeprecationNotification: Notification;
begin
DeprecationNotification.Id := ExtensionManagementDeprecationNotificationIdTok;
DeprecationNotification.Scope := NotificationScope::LocalScope;
DeprecationNotification.Message(ExtensionManagementDeprecationMsg);
DeprecationNotification.AddAction(ReadMoreHereLbl, Codeunit::"Extension Operation Impl", 'OpenAdminCenterExtensionManagementDocumentation');
DeprecationNotification.Send();
end;

local procedure ShowUninstalledExtensionsNotification()
var
ExtensionDatabaseSnapshot: Record "Extension Database Snapshot";
Expand Down Expand Up @@ -429,6 +444,9 @@ page 2500 "Extension Management"
ShowOrphanedDataLbl: Label 'Show Data';
MarkAllAsReviewedLbl: Label 'Mark All as Reviewed';
OrphanedDataNotificationIdTok: Label 'b1c5a678-2e3f-4d91-a6b0-9f8e7d6c5b4a', Locked = true;
ExtensionManagementDeprecationMsg: Label 'Extension management is moving to the Business Central admin center. Use the admin center to upload and manage per-tenant extensions. This page will become unavailable in a future release.';
ReadMoreHereLbl: Label 'Read more here';
ExtensionManagementDeprecationNotificationIdTok: Label '3be91c11-8195-4c65-be23-20fddbea9bb7', Locked = true;

protected procedure IsSaasEnvironment(): boolean
begin
Expand Down
6 changes: 6 additions & 0 deletions src/System Application/App/Extension Management/src/ExtensionOperationImpl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ codeunit 2503 "Extension Operation Impl"
InstallationFailedOpenDetailsTxt: Label 'App installation failed. User has chosen to see the details.';
InstallationFailedDoNotOpenDetailsTxt: Label 'App installation failed. User has chosen not to check out the details.';
PageCaptionTok: Label '%1 %2', Comment = '%1 = Page default caption %2 = App name';
AdminCenterExtensionManagementUrlLbl: Label 'https://go.microsoft.com/fwlink/?LinkId=2374621', Locked = true;

local procedure AssertIsInitialized()
begin
Expand Down Expand Up @@ -149,6 +150,11 @@ codeunit 2503 "Extension Operation Impl"
exit(true);
end;

procedure OpenAdminCenterExtensionManagementDocumentation(Notification: Notification)
begin
Hyperlink(AdminCenterExtensionManagementUrlLbl);
end;

procedure UnpublishUninstalledPerTenantExtension(PackageID: Guid)
begin
CheckPermissions();
Expand Down
4 changes: 3 additions & 1 deletion src/System Application/App/Extension Management/src/UploadAndDeployExtension.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ using System.Globalization;
page 2507 "Upload And Deploy Extension"
{
Extensible = false;
ObsoleteReason = 'Use the Business Central admin center to upload and manage per-tenant extensions.';
ObsoleteState = Pending;
ObsoleteTag = '29.0';
PageType = NavigatePage;
SourceTable = "Published Application";
SourceTableTemporary = true;
Expand Down Expand Up @@ -183,4 +186,3 @@ page 2507 "Upload And Deploy Extension"
DisclaimerLbl: Label 'Per-Tenant Extension (PTE) Disclaimer';
IsAccepted: Boolean;
}

Loading