[28.x] Re-enable AppSourceCop rules after Subcontracting renumbering

[Chethan Thopaiah (ChethanT)]

What & why

Re-enables the AppSourceCop rules that were temporarily disabled for the Subcontracting object renumbering and removes the temporary AS0072/AS0136 pragmas added to the Subcontracting app.

This PR contains only ruleset and pragma cleanup. It does not change application behavior.

Rules re-enabled

• AS0001
• AS0018
• AS0029
• AS0088
• AS0106

Linked work

Fixes AB#646188

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR removes the temporary #pragma warning disable/restore AS0072, AS0136 pragmas that were added to Subcontracting app files during object renumbering, and re-enables five AppSourceCop rules (AS0001, AS0018, AS0029, AS0088, AS0106) in the global AppSourceCop.ruleset.json that were also temporarily suppressed for the same reason.

The change is correct and complete. All 169 disable/restore pragma pairs are removed from the Subcontracting app — a grep of the post-PR tree confirms no AS0072 or AS0136 suppressions remain. The ruleset changes revert the five entries cleanly from "action": "None" with a now-stale justification to "action": "Error", restoring enforcement. No application logic is touched anywhere in the diff.

Suggestions

None.

Risk assessment and necessity

Risk: Near zero. The diff contains no executable code — only pragma directives and ruleset JSON. Re-enabling the rules adds compiler enforcement; if any violation were missed, CI would catch it before merge. The shared ruleset applies to all apps, but since the renumbering is complete there should be no remaining violations in any Subcontracting object.

Necessity: Necessary and timely. Leaving temporary suppressions in place after the renumbering is done creates false noise and risks masking future real violations of AS0001, AS0018, AS0029, AS0088, and AS0106. Removing them as a dedicated cleanup PR — targeting the same releases/28.x branch where the renumbering happened — is the right approach.

---

[AI-PR-REVIEW] version=1 promptVersion=1 system=github pr=10054 round=1 by=alexei-dobriansky at=2026-08-10T07:52:52Z lastSha=afca7bf41f5d56bfa014534702e6354d93aefdf4 reviewKey=8ae3c3dd71a9fd43297ec5dc62452843bbc6a47f4810e78726af0608d7485c9e suggestions=

[alexei-dobriansky]

Agentic PR Review - Round 2

Recommendation: Accept

What this PR does

This PR removes the temporary #pragma warning disable/restore AS0072, AS0136 pragma pairs from all Subcontracting app files and re-enables five AppSourceCop rules in AppSourceCop.ruleset.json. The round-1 review already confirmed the cleanup was correct and complete.

The single new commit since round 1 updates build/Packages.json to bump the AppBaselines-BCArtifacts version from 28.3.52162.52957 to 28.4.53241.53522. This is a routine baseline version bump required to keep CI artifact resolution aligned with the new BC 28.4 release. It does not change the ruleset or pragma cleanup that is the subject of this PR.

Status of previous suggestions

No suggestions were raised in round 1.

New observations (commits since round 1)

No new concerns. The baseline bump in build/Packages.json is a routine maintenance change with no impact on application behavior or AppSourceCop enforcement.

Risk assessment and necessity

Risk: Near zero. The only new change is a CI baseline version bump — no executable code or ruleset logic is touched. The pragma cleanup reviewed in round 1 remains unchanged.

Necessity: The baseline update is necessary for CI to resolve BC 28.4 artifacts. The overall PR remains required to restore AppSourceCop enforcement after the Subcontracting renumbering.

---

[AI-PR-REVIEW] version=1 promptVersion=1 system=github pr=10054 round=2 by=alexei-dobriansky at=2026-08-11T09:39:30Z lastSha=a3bda9bf589cfdb42f3b58eee2c9fc25b98bb908 reviewKey=b0cba9fe2431d9cfd8fd8ae560c916c3546a1b535f299d4da99dd534e995de54 suggestions= parentRound=1