Skip to content

[28.x] ABC Analysis page - improve caption - #8597

Open
attilatoury wants to merge 1 commit into
releases/28.xfrom
backport/releases/28.x/637463
Open

[28.x] ABC Analysis page - improve caption#8597
attilatoury wants to merge 1 commit into
releases/28.xfrom
backport/releases/28.x/637463

Conversation

@attilatoury

@attilatoury attilatoury commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Backport of #8422 to releases/28.x.

Changes page 37111 PowerBI ABC Analysis caption from 'ABC Analysis' to 'ABC Analysis (Power BI)' so it can be distinguished from the Excel-based Item - ABC Analysis report when using Tell Me.

Related ADO work item: AB#637463

Backport of #8422 to releases/28.x. Changes page 37111 caption to 'ABC Analysis (Power BI)' to distinguish from the Excel report.
@attilatoury
attilatoury requested a review from a team as a code owner June 12, 2026 14:06
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 12, 2026
@github-actions github-actions Bot added this to the Version 28.3 milestone Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@attilatoury attilatoury reopened this Jun 18, 2026
@attilatoury
attilatoury requested a review from a team June 18, 2026 09:12
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@attilatoury attilatoury reopened this Jun 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@attilatoury attilatoury reopened this Jul 10, 2026
@github-actions github-actions Bot modified the milestones: Version 28.3, Version 28.4 Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) added Finance GitHub request for Finance area SCM GitHub request for SCM area Ownership: Manual Preserve the manually selected team ownership and removed Finance GitHub request for Finance area labels Jul 16, 2026
@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) removed the Ownership: Manual Preserve the manually selected team ownership label Jul 17, 2026
@attilatoury attilatoury reopened this Jul 20, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept with Suggestions

What this PR does

This PR changes the caption of page 37111 PowerBI ABC Analysis from 'ABC Analysis' to 'ABC Analysis (Power BI)'. This makes the Power BI page easy to tell apart from the Excel-based report 723 Item - ABC Analysis when a user searches in Tell Me. This is a backport of #8422 to releases/28.x.

The change is correct and matches the linked work item exactly. The work item asks for two captions: report 723 should read Item - ABC Analysis (Excel) and page 37111 should read ABC Analysis (Power BI). Report 723 lives in BaseApp, not in this repo, so it is out of scope here and already carries the (Excel) caption; this PR correctly handles only the page that belongs to BCApps. No behavior changes, only the display caption.

Suggestions

S1 - AboutText still describes customer segmentation
The AboutText on this page says the report is about "customer segmentation based on sales volume". This is an item ABC analysis, not a customer one, so the text is misleading. Since this PR improves clarity, consider fixing this text in the same change. This is optional and does not block the fix.

Risk assessment and necessity

Risk: Very low. This is a caption-only change on a single page object; there is no logic, data, or API impact, and no test is warranted or feasible for a caption string. Note that the Build Apps (W1) (DK) check and the aggregate Pull Request Status Check are red, but the failure is unrelated to this change: the log shows Unable to extract and analyze appFile ... Subscription Billing ... .app during dependency sorting in BcContainerHelper, which is a build-infrastructure error, not a compilation error from the caption. A fresh build run should clear it; please confirm a green build before merging.

Necessity: Justified. The linked work item AB#637463 is a valid, closed bug (Severity 3, found via manual smoke test) reporting that the Excel and Power BI ABC analysis reports cannot be told apart in Tell Me. The scope is right: this backport touches only the one page owned by this repo, and matches the exact caption text requested in the work item.


[AI-PR-REVIEW] version=1 system=github pr=8597 round=1 by=alexei-dobriansky at=2026-08-04T05:48:29Z lastSha=16fa8c0cdc4b4f9ddbc30b5aaef23de884b7343f suggestions=S1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants