Fix missing properties in OpenFolderSchema.json.lci#1515
Merged
gregg-miskelly merged 1 commit intoSep 3, 2025
Conversation
A number of fields in OpenFolderSchema.json were being localized that shouldn't have been. This fixes OpenFolderSchema.json.lci to hopefully fix this.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes localization issues in OpenFolderSchema.json by adding missing properties to the .lci file that should not be localized. The changes ensure that specific schema type definitions and references are properly marked as locked in the localization configuration.
- Adds missing type definitions for debug extension properties that were being incorrectly localized
- Corrects existing anyOf array item references for sourceFileMap properties
- Ensures all added entries are marked with
{Locked}comment to prevent localization
Comments suppressed due to low confidence (2)
loc/lci/OpenFolderSchema.json.lci:1
- The ItemId changes appear to be reordering array elements, but the original anyOf.$ref and anyOf.type entries are being replaced with anyOf[0].type and anyOf[1].$ref respectively. This seems to swap the order of type and $ref properties, which could affect the schema validation logic. Verify that this reordering matches the intended schema structure.
<?xml version="1.0" encoding="utf-8"?>
loc/lci/OpenFolderSchema.json.lci:1
- The ItemId changes appear to be reordering array elements, but the original anyOf.$ref and anyOf.type entries are being replaced with anyOf[0].type and anyOf[1].$ref respectively. This seems to swap the order of type and $ref properties, which could affect the schema validation logic. Verify that this reordering matches the intended schema structure.
<?xml version="1.0" encoding="utf-8"?>
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WardenGnaw
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of fields in OpenFolderSchema.json were being localized that shouldn't have been. This fixes OpenFolderSchema.json.lci to hopefully fix this.