Skip to content

Fix missing properties in OpenFolderSchema.json.lci#1515

Merged
gregg-miskelly merged 1 commit into
microsoft:mainfrom
gregg-miskelly:OpenFolderSchemaLocFixes
Sep 3, 2025
Merged

Fix missing properties in OpenFolderSchema.json.lci#1515
gregg-miskelly merged 1 commit into
microsoft:mainfrom
gregg-miskelly:OpenFolderSchemaLocFixes

Conversation

@gregg-miskelly

Copy link
Copy Markdown
Member

A number of fields in OpenFolderSchema.json were being localized that shouldn't have been. This fixes OpenFolderSchema.json.lci to hopefully fix this.

A number of fields in OpenFolderSchema.json were being localized that shouldn't have been. This fixes OpenFolderSchema.json.lci to hopefully fix this.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes localization issues in OpenFolderSchema.json by adding missing properties to the .lci file that should not be localized. The changes ensure that specific schema type definitions and references are properly marked as locked in the localization configuration.

  • Adds missing type definitions for debug extension properties that were being incorrectly localized
  • Corrects existing anyOf array item references for sourceFileMap properties
  • Ensures all added entries are marked with {Locked} comment to prevent localization
Comments suppressed due to low confidence (2)

loc/lci/OpenFolderSchema.json.lci:1

  • The ItemId changes appear to be reordering array elements, but the original anyOf.$ref and anyOf.type entries are being replaced with anyOf[0].type and anyOf[1].$ref respectively. This seems to swap the order of type and $ref properties, which could affect the schema validation logic. Verify that this reordering matches the intended schema structure.
<?xml version="1.0" encoding="utf-8"?>

loc/lci/OpenFolderSchema.json.lci:1

  • The ItemId changes appear to be reordering array elements, but the original anyOf.$ref and anyOf.type entries are being replaced with anyOf[0].type and anyOf[1].$ref respectively. This seems to swap the order of type and $ref properties, which could affect the schema validation logic. Verify that this reordering matches the intended schema structure.
<?xml version="1.0" encoding="utf-8"?>

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gregg-miskelly gregg-miskelly merged commit da2c6cc into microsoft:main Sep 3, 2025
6 checks passed
@gregg-miskelly gregg-miskelly deleted the OpenFolderSchemaLocFixes branch September 3, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants