Skip to content

Fix Natvis not resolving for template args with negative constant #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregg-miskelly merged 1 commit into from
Sep 23, 2025
Merged

Fix Natvis not resolving for template args with negative constant #1524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MIDebugEngine/Natvis.Impl/NatvisNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ private void SetArraySize(int[] Dims)
}

private static Regex s_identifier = new Regex("^[a-zA-Z$_][a-zA-Z$_0-9]*");
private static Regex s_numeric = new Regex("^[0-9]+(u|l|ul)*"); // only decimal constants
private static Regex s_numeric = new Regex("^[-]?[0-9]+(u|l|ul)*"); // only decimal constants
private static Regex s_simpleType = new Regex(
@"^(signed\s+char|unsigned\s+char|char16_t|char32_t|wchar_t|char|"
+ @"signed\s+short\s+int|signed\s+short|unsigned\s+short\s+int|unsigned\s+short|short\s+int|short|"
Expand Down
Loading