Skip to content

chore: fix accumulation logic for PrimeField vectors #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdqst wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: fix accumulation logic for PrimeField vectors #416

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8804cb
chore: fix accumulation logic for `PrimeField` vectors
mdqst Oct 13, 2025
bc24296
Merge branch 'main' into patch-1
srinathsetty Dec 4, 2025
72bdd1a
Update sparse.rs
mdqst Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/r1cs/sparse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
self
.get_row_unchecked(ptrs.try_into().unwrap())
.map(|(val, col_idx)| *val * vector[*col_idx])
.sum()
.fold(F::zero(), |acc, x| acc + x)

Check failure on line 94 in src/r1cs/sparse.rs

View workflow job for this annotation

GitHub Actions / clippy 

no function or associated item named `zero` found for type parameter `F` in the current scope

Check failure on line 94 in src/r1cs/sparse.rs

View workflow job for this annotation

GitHub Actions / clippy 

no function or associated item named `zero` found for type parameter `F` in the current scope

Check failure on line 94 in src/r1cs/sparse.rs

View workflow job for this annotation

GitHub Actions / build-wasm 

no function or associated item named `zero` found for type parameter `F` in the current scope

Check failure on line 94 in src/r1cs/sparse.rs

View workflow job for this annotation

GitHub Actions / test 

no function or associated item named `zero` found for type parameter `F` in the current scope

Check failure on line 94 in src/r1cs/sparse.rs

View workflow job for this annotation

GitHub Actions / build 

no function or associated item named `zero` found for type parameter `F` in the current scope
})
.collect()
}
Expand Down
Loading