Skip to content

Updates gadgets to make namespace pushing more consistent#495

Merged
srinathsetty merged 2 commits into
mainfrom
namespace
May 18, 2026
Merged

Updates gadgets to make namespace pushing more consistent#495
srinathsetty merged 2 commits into
mainfrom
namespace

Conversation

@MercysJest
Copy link
Copy Markdown
Contributor

  • Adds a namespace push when calling field_into_allocated_bits_le
  • Remove unnecessary helper function triop to flatten function call stack.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes gadget namespace handling more consistent and flattens the UInt32 SHA-256 helper implementation without changing the intended gadget behavior.

Changes:

  • Inlined the removed triop helper into sha256_maj and sha256_ch.
  • Added an explicit namespace around field_into_allocated_bits_le.
  • Bumped the crate patch version to 0.71.1.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/frontend/gadgets/uint32.rs Removes triop and directly implements SHA-256 maj/ch UInt32 helpers.
src/frontend/gadgets/num.rs Wraps bit allocation in a dedicated namespace.
Cargo.toml Updates package version from 0.71.0 to 0.71.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/frontend/gadgets/uint32.rs
@srinathsetty srinathsetty added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit 21751a6 May 18, 2026
12 checks passed
@MercysJest MercysJest deleted the namespace branch May 18, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants