Skip to content

[KeyboardManager] Fix sticky Ctrl caused by stale AltGr flag #46672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fluffyspace wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[KeyboardManager] Fix sticky Ctrl caused by stale AltGr flag #46672

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
389d286
[KeyboardManager] Fix sticky Ctrl caused by stale isAltRightKeyInvoke…
fluffyspace Mar 31, 2026
b59657e
[KeyboardManager] Add tests for AltGr stale flag causing sticky Ctrl
fluffyspace Apr 1, 2026
d495a2a
[KeyboardManager] Gate AltGr flag set to key-down only
fluffyspace Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,10 @@ namespace KeyboardEventHandlers
{
isAltRightKeyInvoked = true;
}
else if (data->lParam->vkCode == VK_RMENU && (data->wParam == WM_KEYUP || data->wParam == WM_SYSKEYUP))
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new reset branch for isAltRightKeyInvoked can be skipped on VK_RMENU key-up events: the preceding if (vkCode == VK_RMENU && ii.GetVirtualKeyState(VK_LCONTROL)) also runs on key-up, and if VK_LCONTROL is still reported as down at that moment (common with AltGr), it will set the flag back to true and prevent the reset. To ensure the flag is reliably cleared on release, handle the key-up case first (or gate the "set" branch to key-down only).

Copilot uses AI. Check for mistakes.
{
isAltRightKeyInvoked = false;
}

// If the shortcut has been pressed down
if (!it->second.isShortcutInvoked && it->first.CheckModifiersKeyboardState(ii))
Expand Down
Loading