Add unit tests for PowerAccent.Core and Peek.Common helpers by Copilot · Pull Request #46684 · microsoft/PowerToys

Copilot · 2026-03-31T20:06:42Z

Summary of the Pull Request

Adds 105 unit tests across two new test projects for modules with zero prior test coverage: PowerAccent.Core (geometric types, toolbar positioning, language character mappings) and Peek.Common (math helpers, UNC path detection).

Checked existing open PRs (#46679 covers Hosts/ColorPicker, #45375 covers StringTruncationHelper) to avoid duplication.

PR Checklist

Detailed Description of the Pull Request / Additional comments

PowerAccent.Core.UnitTests (new project, 72 tests)

PointTests, SizeTests, RectTests — Constructors (default, int, double, composite), division operators (scalar + componentwise), DivideByZeroException guards, implicit conversions from System.Drawing types
CalculationTests — GetRawCoordinatesFromCaret: left/right/top boundary clamping, multi-monitor offset screens. GetRawCoordinatesFromPosition: all 9 Position enum values at DPI 1.0/1.5/2.0, verifying offset and window-size scaling
LanguagesTests — Empty/single/multi-language arrays, deduplication across combined languages, known accent verification (French à/â/æ, German ö/ü/ß, Spanish ñ, Czech č, Polish ł, Vietnamese multi-diacritics), special characters (subscript/superscript/fractions), _allLanguagesCache hit, exhaustive LetterKey sweep with no-duplicate assertion

Added InternalsVisibleTo on PowerAccent.Core.csproj → PowerToys.PowerAccent.Core.UnitTests (follows existing pattern in imageresizer, CmdPal, MouseJump, etc.).

Peek.Common.UnitTests (new project, 33 tests)

MathHelperTests — Modulo: proper wrapping for negative dividends (e.g. Modulo(-1, 3) == 2), zero, exact division, large values. NumberOfDigits: zero, negatives, powers-of-ten boundaries (9→10, 99→100), int.MaxValue
PathHelperTests — IsUncPath: standard UNC, IP-based, dotted FQDN servers → true; local drives, relative paths, HTTP URLs, file:/// URIs, single backslash, empty string → false

Solution and CI integration

Added both PowerAccent.Core.UnitTests and Peek.Common.UnitTests to PowerToys.slnx with ARM64/x64 platform configurations so CI builds and discovers the tests via the existing **\*UnitTest*.dll VSTest pattern.
Imported Common.SelfContained.props in both test projects to pin SelfContained=true and RuntimeIdentifier, ensuring the deps.json resolves the same .NET runtime version as the rest of the solution (fixes verifyDepsJsonLibraryVersions.ps1 audit step).

Spell-check allow/expect list updates

Added Ene, traies, udit to .github/actions/spell-check/allow/code.txt to resolve unrecognized-spelling alerts
Removed unused entries from .github/actions/spell-check/expect.txt: LPCFHOOKPROC, LUMA, MAXDWORD, MRT, VSync

StyleCop and build compliance

Removed all #region/#endregion directives from test files to fix SA1124 errors
Added explicit using System; to PointTests.cs, SizeTests.cs, RectTests.cs, and LanguagesTests.cs for DivideByZeroException, Array, and Enum types (ImplicitUsings is disabled globally in Directory.Build.props)
Added explicit using System.Linq; to LanguagesTests.cs for Distinct() and Count() extension methods
Removed blank lines before closing braces in LanguagesTests.cs, CalculationTests.cs, MathHelperTests.cs, and PathHelperTests.cs to fix SA1508 errors

Validation Steps Performed

Verified test files follow existing MSTest patterns ([TestClass], [TestMethod], [DataRow]) consistent with repo conventions
Verified all referenced classes/methods exist and are accessible (correct namespaces, visibility via InternalsVisibleTo)
Verified namespace consistency with existing test projects
Verified both test projects are included in PowerToys.slnx for CI discovery
Verified no #region directives remain (SA1124 compliance)
Verified no blank lines before closing braces remain (SA1508 compliance)
Verified explicit using directives are present for all required namespaces (repo disables ImplicitUsings globally), including using System; for DivideByZeroException, Array, Enum and using System.Linq; for LINQ extension methods
Verified both test projects import Common.SelfContained.props to pin .NET runtime version consistently with the rest of the solution (deps.json audit compliance)
CodeQL scan returned no alerts

Add PowerAccent.Core.UnitTests project with tests for: - Point, Size, Rect struct constructors and division operators - Calculation position logic with boundary conditions and DPI - Languages character mapping for multiple languages Add Peek.Common.UnitTests project with tests for: - MathHelper.Modulo with positive/negative values - MathHelper.NumberOfDigits with edge cases - PathHelper.IsUncPath with various path formats Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/643cb57b-c352-45a6-83d0-d6b09011290b Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

src/modules/poweraccent/PowerAccent.Core.UnitTests/LanguagesTests.cs

crutkas · 2026-03-31T20:37:22Z

@copilot add Ene to https://github.com/microsoft/PowerToys/blob/main/.github/actions/spell-check/allow/code.txt

remove the following list LPCFHOOKPROC LUMA MAXDWORD MRT VSync

… expect list Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/717795b3-9c5f-484e-9b9c-63de37852f81 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-03-31T20:39:29Z

@copilot add Ene to https://github.com/microsoft/PowerToys/blob/main/.github/actions/spell-check/allow/code.txt

remove the following list LPCFHOOKPROC LUMA MAXDWORD MRT VSync

Added Ene to .github/actions/spell-check/allow/code.txt and removed LPCFHOOKPROC, LUMA, MAXDWORD, MRT, VSync from .github/actions/spell-check/expect.txt in b5373cb.

crutkas · 2026-03-31T20:58:17Z

/azp run

azure-pipelines · 2026-03-31T20:58:27Z

Azure Pipelines successfully started running 1 pipeline(s).

crutkas · 2026-04-01T04:25:48Z

@copilot this claims 95 new tests but the test count doesn't reflect that

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/9ffea101-795b-4b8c-817a-ab5af7004f72 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-04-01T04:41:07Z

@copilot this claims 95 new tests but the test count doesn't reflect that

The test projects were missing from PowerToys.slnx, so CI wasn't building or discovering them. Added both PowerAccent.Core.UnitTests and Peek.Common.UnitTests to the solution file in 1254cba. There are 105 test methods total (72 PowerAccent + 33 Peek).

crutkas · 2026-04-01T13:33:37Z

/azp run

azure-pipelines · 2026-04-01T13:33:49Z

Azure Pipelines successfully started running 1 pipeline(s).

crutkas · 2026-04-01T20:16:59Z

@copilot fix SA1124 errors

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/00075017-9397-4cb6-ad53-1afda756d401 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-04-01T20:20:39Z

@copilot fix SA1124 errors

Removed all #region/#endregion directives from LanguagesTests.cs, CalculationTests.cs, MathHelperTests.cs, and PathHelperTests.cs in 1eca171.

crutkas · 2026-04-03T01:26:45Z

@copilot fix spelling errors

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/1daa557f-51f2-454e-a7f9-aacc3912d36f Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-04-03T01:42:22Z

@copilot fix spelling errors

Added traies and udit (the 2 unrecognized words from the @check-spelling-bot report) to .github/actions/spell-check/allow/code.txt in ce6debf.

crutkas · 2026-04-04T04:55:08Z

@copilot fix the build errors.

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/0b83d8fc-328d-47ec-a746-685956604afe Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-04-04T05:08:22Z

@copilot fix the build errors.

Added missing using System.Linq; to LanguagesTests.cs in c72580c. The Distinct() and Count() LINQ extension methods require this explicit import since ImplicitUsings is disabled globally in Directory.Build.props.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dev.azure.com
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
https://api.github.com/repos/microsoft/PowerToys/check-runs/69833939834/annotations
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)
https://api.github.com/repos/microsoft/PowerToys/check-runs/69834264090/annotations
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)
o3svsblobprodcus318.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore src/modules/peek/Peek.Common.UnitTests/Peek.Common.UnitTests.csproj --verbosity minimal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

crutkas · 2026-04-05T00:28:47Z

/azp run

azure-pipelines · 2026-04-05T00:28:58Z

Azure Pipelines successfully started running 1 pipeline(s).

crutkas · 2026-04-05T16:34:28Z

@copilot SA1508 and CS0246 errors, please fix

…missing using System Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/a6ae0e3d-68ed-4a4f-8b91-e039e2f05689 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-04-05T16:39:31Z

@copilot SA1508 and CS0246 errors, please fix

Fixed both in fb7c945:

SA1508: Removed blank lines before closing braces in LanguagesTests.cs, CalculationTests.cs, MathHelperTests.cs, and PathHelperTests.cs
CS0246: Added missing using System; to PointTests.cs, SizeTests.cs, RectTests.cs, and LanguagesTests.cs (needed for DivideByZeroException, Array, Enum since ImplicitUsings is disabled globally)

crutkas · 2026-04-05T17:52:55Z

/azp run

azure-pipelines · 2026-04-05T17:53:08Z

Azure Pipelines successfully started running 1 pipeline(s).

crutkas · 2026-04-05T23:10:54Z

@copilot 'Audit deps.json files for all applications' failed. PowerToys.Peek.Common.UnitTests.deps.json shows it is on the wrong version, it is showing 9.0.1025.47515 when the rest of the solution is on 9.0.1426.11910. AdvancedPaste.UnitTests.deps.json does show correctly.

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/a7787ea5-42eb-4e09-96c8-c295385faa9c Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot · 2026-04-05T23:15:23Z

@copilot 'Audit deps.json files for all applications' failed. PowerToys.Peek.Common.UnitTests.deps.json shows it is on the wrong version, it is showing 9.0.1025.47515 when the rest of the solution is...

Added <Import Project="$(RepoRoot)src\Common.SelfContained.props" /> to both Peek.Common.UnitTests.csproj and PowerAccent.Core.UnitTests.csproj in 70dd9db. This pins SelfContained=true and RuntimeIdentifier so the deps.json resolves the same .NET runtime version (9.0.1426.11910) as the rest of the solution.

crutkas · 2026-04-06T01:38:03Z

/azp run

azure-pipelines · 2026-04-06T01:38:14Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI assigned Copilot and crutkas Mar 31, 2026

Copilot created this pull request from a session on behalf of crutkas March 31, 2026 20:06 View session

github-advanced-security bot found potential problems Mar 31, 2026

View reviewed changes

src/modules/poweraccent/PowerAccent.Core.UnitTests/LanguagesTests.cs Fixed Show fixed Hide fixed

This comment has been minimized.

Sign in to view

Copilot started work on behalf of crutkas March 31, 2026 20:37 View session

Update spell-check: add Ene to allow list, remove unused entries from…

b5373cb

… expect list Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/717795b3-9c5f-484e-9b9c-63de37852f81 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot AI requested a review from crutkas March 31, 2026 20:40

Copilot finished work on behalf of crutkas March 31, 2026 20:40

Copilot started work on behalf of crutkas April 1, 2026 04:25 View session

Add test projects to PowerToys.slnx so CI discovers and runs them

1254cba

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/9ffea101-795b-4b8c-817a-ab5af7004f72 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot finished work on behalf of crutkas April 1, 2026 04:44

Copilot started work on behalf of crutkas April 1, 2026 20:17 View session

Remove all #region/#endregion directives to fix SA1124 errors

1eca171

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/00075017-9397-4cb6-ad53-1afda756d401 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot finished work on behalf of crutkas April 1, 2026 20:21

This comment has been minimized.

Sign in to view

Copilot started work on behalf of crutkas April 3, 2026 01:26 View session

Add traies and udit to spell-check allow list

ce6debf

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/1daa557f-51f2-454e-a7f9-aacc3912d36f Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot finished work on behalf of crutkas April 3, 2026 01:43

crutkas marked this pull request as ready for review April 3, 2026 09:52

Copilot started work on behalf of crutkas April 4, 2026 04:55 View session

Fix build error: add missing using System.Linq to LanguagesTests.cs

c72580c

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/0b83d8fc-328d-47ec-a746-685956604afe Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot finished work on behalf of crutkas April 4, 2026 05:09

Copilot started work on behalf of crutkas April 5, 2026 16:34 View session

Fix SA1508 and CS0246: remove blank lines before closing braces, add …

fb7c945

…missing using System Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/a6ae0e3d-68ed-4a4f-8b91-e039e2f05689 Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot finished work on behalf of crutkas April 5, 2026 16:39

Copilot started work on behalf of crutkas April 5, 2026 23:12 View session

Fix deps.json version mismatch: add SelfContained props to test projects

70dd9db

Agent-Logs-Url: https://github.com/microsoft/PowerToys/sessions/a7787ea5-42eb-4e09-96c8-c295385faa9c Co-authored-by: crutkas <1462282+crutkas@users.noreply.github.com>

Copilot finished work on behalf of crutkas April 5, 2026 23:16

Conversation

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

PowerAccent.Core.UnitTests (new project, 72 tests)

Peek.Common.UnitTests (new project, 33 tests)

Solution and CI integration

Spell-check allow/expect list updates

StyleCop and build compliance

Validation Steps Performed

Uh oh!

Uh oh!

This comment has been minimized.

crutkas commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

crutkas commented Mar 31, 2026

Uh oh!

azure-pipelines bot commented Mar 31, 2026

Uh oh!

crutkas commented Apr 1, 2026

Uh oh!

Copilot AI commented Apr 1, 2026

Uh oh!

crutkas commented Apr 1, 2026

Uh oh!

azure-pipelines bot commented Apr 1, 2026

Uh oh!

crutkas commented Apr 1, 2026

Uh oh!

Copilot AI commented Apr 1, 2026

Uh oh!

This comment has been minimized.

crutkas commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

crutkas commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

crutkas commented Apr 5, 2026

Uh oh!

azure-pipelines bot commented Apr 5, 2026

Uh oh!

crutkas commented Apr 5, 2026

Uh oh!

Copilot AI commented Apr 5, 2026

Uh oh!

crutkas commented Apr 5, 2026

Uh oh!

azure-pipelines bot commented Apr 5, 2026

Uh oh!

crutkas commented Apr 5, 2026

Uh oh!

Copilot AI commented Apr 5, 2026

Uh oh!

crutkas commented Apr 6, 2026

Uh oh!

azure-pipelines bot commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 31, 2026 •

edited

Loading

Copilot AI commented Apr 4, 2026 •

edited

Loading