Make PowerShell script invocation more reliable#46729
Open
flcdrg wants to merge 1 commit intomicrosoft:mainfrom
Open
Make PowerShell script invocation more reliable#46729flcdrg wants to merge 1 commit intomicrosoft:mainfrom
flcdrg wants to merge 1 commit intomicrosoft:mainfrom
Conversation
flcdrg
force-pushed
the
powershell-hardening
branch
from
29c5aa8 to
1c9a591
Compare
flcdrg
force-pushed
the
powershell-hardening
branch
from
1c9a591 to
d108e74
Compare
- Protect against issues caused from loading default profile - Ignore any warnings that may be generated by auto-loaded modules. Warnings are written to stderr which the Exec then interprets as an error Fixes microsoft#46618
flcdrg
force-pushed
the
powershell-hardening
branch
from
d108e74 to
77eab34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
The build contains PowerShell invocations. The issue with these prior to this change is that they are vulnerable to what ever may be in the current user's PowerShell profile script.
They are also vulnerable to any auto-loaded PowerShell modules that may generate warnings, as the warning output is interpreted as an error by the MSBuild
Exectask.Validation Steps Performed