Skip to content

CmdPal: Wire up ILogger<T> in ShellViewModel and PowerToysRootPageService #46779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −17

CmdPal: Wire up ILogger<T> in ShellViewModel and PowerToysRootPageSer…

e222389
Select commit
Loading
Failed to load commit list.
Draft

CmdPal: Wire up ILogger<T> in ShellViewModel and PowerToysRootPageService #46779

CmdPal: Wire up ILogger<T> in ShellViewModel and PowerToysRootPageSer…
e222389
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PowerToys CI (Build arm64 Build Release_arm64) failed Apr 6, 2026 in 24m 52s

Build arm64 Build Release_arm64 failed

10 errors / 29 warnings

Annotations

Check failure on line 67 in src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PowerToys CI (Build arm64 Build Release_arm64)

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs#L67 

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs(67,25): Error CA1848: For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogError(ILogger, Exception?, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)

Check failure on line 173 in src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PowerToys CI (Build arm64 Build Release_arm64)

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs#L173 

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs(173,29): Error CA1848: For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogError(ILogger, Exception?, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)

Check failure on line 191 in src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PowerToys CI (Build arm64 Build Release_arm64)

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs#L191 

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs(191,45): Error CA1848: For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogError(ILogger, Exception?, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)

Check failure on line 221 in src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PowerToys CI (Build arm64 Build Release_arm64)

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs#L221 

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs(221,25): Error CA1848: For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogError(ILogger, Exception?, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)

Check failure on line 251 in src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PowerToys CI (Build arm64 Build Release_arm64)

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs#L251 

src\modules\cmdpal\Microsoft.CmdPal.UI.ViewModels\ShellViewModel.cs(251,17): Error CA1848: For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogError(ILogger, Exception?, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
View more details on Azure Pipelines