[KBM] Fixes to text replacement issues#46794
Open
Jaylyn-Barbee wants to merge 2 commits intomicrosoft:mainfrom
Open
[KBM] Fixes to text replacement issues#46794Jaylyn-Barbee wants to merge 2 commits intomicrosoft:mainfrom
Jaylyn-Barbee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Jaylyn-Barbee
added
the
Product-Keyboard Shortcut Manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR attempts to fix some of the issues that were introduced in 0.98.0 with text replacement
PR Checklist
Detailed Description of the Pull Request / Additional comments
In 0.98.0 I made a change to support multiline text replacement using Ctrl + V. This was very inconsistent so I have reverted back to basically the same approach we were using before except now when we encounter a newline indicator we send "Shift + Enter" so that this works in chat boxes and plan editors.
Validation Steps Performed
Manual testing with single line and multiline replacements in Teams, Terminal, Git bash, Edge, etc