-
Notifications
You must be signed in to change notification settings - Fork 848
FIX: report initializer catalog outages as unavailable, not unregistered #2469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fei (feiiiiii5)
wants to merge
4
commits into
microsoft:main
from
feiiiiii5:issue2442/catalog-unavailable-copy
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3fb8278
FIX: report initializer catalog outages as unavailable, not unregiste…
feiiiiii5 ddf816c
fix(frontend): disable initializer editing while the catalog is unava…
feiiiiii5 0463862
Merge branch 'main' into issue2442/catalog-unavailable-copy
hannahwestra25 8bf6e6d
Merge branch 'main' into issue2442/catalog-unavailable-copy
hannahwestra25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m thinking we could replace
catalogAvailablewith a catalog status union such as:We could then keep the catalog entries separately and have the lookup return
RegisteredInitializer | undefinedinstead of constructing syntheticRegisteredInitializerobjects:The renderers could handle each state explicitly:
errorshows the unavailable message without rendering catalog-derived metadata,loadedwith no match shows “no longer registered,” andloadedwith a match renders the real metadata. Browse, Add, and Edit could requireloaded, while Apply and Remove remain available.This would avoid interpreting placeholder empty arrays as “Required env vars: None” or “No declared parameters,” and would also prevent cached catalog data from enabling controls after a failed refresh. Could we also cover initial failure, recovery, and loaded-then-failed-refresh transitions?