fix(workflow): add concurrency control and fix timer race conditions#1347
Open
KhawarHabibKhan wants to merge 3 commits intomicrosoft:mainfrom
Open
fix(workflow): add concurrency control and fix timer race conditions#1347KhawarHabibKhan wants to merge 3 commits intomicrosoft:mainfrom
KhawarHabibKhan wants to merge 3 commits intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
When step_semaphore is configured > 1, multiple async steps can concurrently read/decrement step_n without synchronization, leading to over-execution or missed termination. The timer's is_timeout() also had a TOCTOU race where update_remain_time() and a separate datetime.now() comparison could disagree, and negative _remain_time_duration values could propagate into MLflow metrics.
Types of changes
📚 Documentation preview 📚: https://RDAgent--1347.org.readthedocs.build/en/1347/